You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/08/19 11:08:25 UTC
[GitHub] [solr] janhoy opened a new pull request #268: SOLR-15324 Upgrade Jaeger dependency from 1.1.0 to 1.6.0
janhoy opened a new pull request #268:
URL: https://github.com/apache/solr/pull/268
This also upgrades libthrift to 0.14.1, fixing CVE-2020-13949
https://issues.apache.org/jira/browse/SOLR-15324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #268: SOLR-15324 Upgrade Jaeger dependency from 1.1.0 to 1.6.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #268:
URL: https://github.com/apache/solr/pull/268#discussion_r692017506
##########
File path: versions.lock
##########
@@ -174,11 +174,13 @@ org.apache.poi:poi:4.1.1 (1 constraints: 08050336)
org.apache.poi:poi-ooxml:4.1.1 (1 constraints: 08050336)
org.apache.poi:poi-ooxml-schemas:4.1.1 (1 constraints: 08050336)
org.apache.poi:poi-scratchpad:4.1.1 (1 constraints: 08050336)
-org.apache.thrift:libthrift:0.13.0 (1 constraints: 8e0dfd33)
+org.apache.thrift:libthrift:0.14.1 (1 constraints: 900d0134)
org.apache.tika:tika-core:1.24 (1 constraints: db04f730)
org.apache.tika:tika-java7:1.24 (1 constraints: db04f730)
org.apache.tika:tika-parsers:1.24 (1 constraints: db04f730)
org.apache.tika:tika-xmp:1.24 (1 constraints: db04f730)
+org.apache.tomcat:tomcat-annotations-api:8.5.46 (1 constraints: 5a1162ea)
+org.apache.tomcat.embed:tomcat-embed-core:8.5.46 (1 constraints: 780c4b05)
Review comment:
Would it be safe to exclude these two new tomcat dependencies or are they needed by our use of jaeger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #268: SOLR-15324 Upgrade Jaeger dependency from 1.1.0 to 1.6.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #268:
URL: https://github.com/apache/solr/pull/268#issuecomment-901826860
Test seem to pass, but I don't know if the upgrade will actually work with a live Jaeger server. Anyone who have the chance to test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #268: SOLR-15324 Upgrade Jaeger dependency from 1.1.0 to 1.6.0
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #268:
URL: https://github.com/apache/solr/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #268: SOLR-15324 Upgrade Jaeger dependency from 1.1.0 to 1.6.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #268:
URL: https://github.com/apache/solr/pull/268#discussion_r692145635
##########
File path: versions.lock
##########
@@ -174,11 +174,13 @@ org.apache.poi:poi:4.1.1 (1 constraints: 08050336)
org.apache.poi:poi-ooxml:4.1.1 (1 constraints: 08050336)
org.apache.poi:poi-ooxml-schemas:4.1.1 (1 constraints: 08050336)
org.apache.poi:poi-scratchpad:4.1.1 (1 constraints: 08050336)
-org.apache.thrift:libthrift:0.13.0 (1 constraints: 8e0dfd33)
+org.apache.thrift:libthrift:0.14.1 (1 constraints: 900d0134)
org.apache.tika:tika-core:1.24 (1 constraints: db04f730)
org.apache.tika:tika-java7:1.24 (1 constraints: db04f730)
org.apache.tika:tika-parsers:1.24 (1 constraints: db04f730)
org.apache.tika:tika-xmp:1.24 (1 constraints: db04f730)
+org.apache.tomcat:tomcat-annotations-api:8.5.46 (1 constraints: 5a1162ea)
+org.apache.tomcat.embed:tomcat-embed-core:8.5.46 (1 constraints: 780c4b05)
Review comment:
I excluded them and tests still pass..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org