You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/04/30 10:47:25 UTC
[GitHub] [druid] clintropolis commented on a change in pull request #11126: Add integration test for protobuf
clintropolis commented on a change in pull request #11126:
URL: https://github.com/apache/druid/pull/11126#discussion_r622634039
##########
File path: integration-tests/pom.xml
##########
@@ -466,6 +489,8 @@
<DRUID_INTEGRATION_TEST_SKIP_RUN_DOCKER>${docker.run.skip}</DRUID_INTEGRATION_TEST_SKIP_RUN_DOCKER>
<DRUID_INTEGRATION_TEST_INDEXER>${it.indexer}</DRUID_INTEGRATION_TEST_INDEXER>
<MYSQL_VERSION>${mysql.version}</MYSQL_VERSION>
+ <MYSQL_VERSION>${mysql.version}</MYSQL_VERSION>
Review comment:
nit: duplicate line
##########
File path: integration-tests/pom.xml
##########
@@ -466,6 +489,8 @@
<DRUID_INTEGRATION_TEST_SKIP_RUN_DOCKER>${docker.run.skip}</DRUID_INTEGRATION_TEST_SKIP_RUN_DOCKER>
<DRUID_INTEGRATION_TEST_INDEXER>${it.indexer}</DRUID_INTEGRATION_TEST_INDEXER>
<MYSQL_VERSION>${mysql.version}</MYSQL_VERSION>
+ <MYSQL_VERSION>${mysql.version}</MYSQL_VERSION>
+ <CONFLUENT_VERSION>5.5.1</CONFLUENT_VERSION>
Review comment:
it might make sense to pull this up all the way to the top level `pom.xml`, then here, the avro extension, and the protobuf extension all share it to keep the version synced instead of each defining their own. I do notice that protobuf is using a newer version than avro and here, so I would be ok if we want to save this for a follow-up PR since it wouldn't be directly related adding this integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org