[PR] [ZEPPELIN-3968] Fix wrong MySQL driver class in JDBC doc screenshot [zeppelin]

["kimyenac (via GitHub)" <gi...@apache.org>]

kimyenac opened a new pull request, #5368:
URL: https://github.com/apache/zeppelin/pull/5368

   ### What is this PR for?
   The "Edit Properties" screenshot in the JDBC interpreter documentation shows `default.driver` as `org.mysql.jdbc.Driver`, which is not a real class. Following the docs as written gives a `ClassNotFoundException`.
   
   The correct value is `com.mysql.jdbc.Driver`, which is already what the property tables further down the same page use, so the screenshot was the only place left disagreeing with the rest of the doc.
   
   The screenshot is patched in place rather than recaptured. It dates from the 0.7 era, and a fresh capture would no longer match the surrounding images in the same walkthrough. To keep the font rendering identical, the `c`, `o` and `m` glyphs were taken from elsewhere in the same line of text (`jdbc`, `org`, `mysql`), and the remainder of the string was shifted right by the advance width difference between "org" (1445/1000 em) and "com" (1889/1000 em), about 11px at this scale.
   
   A pixel by pixel comparison against the original confirms only the `default.driver` value changed: 3,387 pixels inside x 936-1171, y 255-278. The surrounding table, the orange highlight box and the arrow annotation are untouched.
   
   ### What type of PR is it?
   Documentation
   
   ### Todos
   * [x] - Fix the driver class name in the screenshot
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-3968
   
   ### How should this be tested?
   Open the "Files changed" tab and use the image diff on `docs/assets/themes/zeppelin/img/docs-img/edit_properties.png`. The `default.driver` row should read `com.mysql.jdbc.Driver`, everything else unchanged.
   
   The image is referenced from `docs/interpreter/jdbc.md`.
   
   ### Screenshots (if appropriate)
   Before: `default.driver` = `org.mysql.jdbc.Driver`
   After: `default.driver` = `com.mysql.jdbc.Driver`
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-3968] Fix wrong MySQL driver class in JDBC doc screenshot [zeppelin]

["tbonelee (via GitHub)" <gi...@apache.org>]

tbonelee commented on PR #5368:
URL: https://github.com/apache/zeppelin/pull/5368#issuecomment-5193157620

   Merged into master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-3968] Fix wrong MySQL driver class in JDBC doc screenshot [zeppelin]

["tbonelee (via GitHub)" <gi...@apache.org>]

tbonelee merged PR #5368:
URL: https://github.com/apache/zeppelin/pull/5368


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org