You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2020/03/26 07:55:40 UTC
[kudu-CR] status callback: replace Bind usage with lambdas
Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15562
to review the following change.
Change subject: status_callback: replace Bind usage with lambdas
......................................................................
status_callback: replace Bind usage with lambdas
StatusCallback was another significant user of kudu::Bind. I've removed it
in favor of StdStatusCallback, which has been renamed to StatusCallback. All
affected Bind users were converted into lambdas.
Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
---
M src/kudu/client/authz_token_cache.cc
M src/kudu/client/batcher.cc
M src/kudu/client/client-internal.cc
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/meta_cache.cc
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_cache-test.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/master/sentry_privileges_fetcher.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/thrift/client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/async_util-test.cc
M src/kudu/util/async_util.h
M src/kudu/util/net/dns_resolver.cc
M src/kudu/util/status_callback.h
30 files changed, 133 insertions(+), 161 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/15562/1
--
To view, visit http://gerrit.cloudera.org:8080/15562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
Gerrit-Change-Number: 15562
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] status callback: replace Bind usage with lambdas
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15562 )
Change subject: status_callback: replace Bind usage with lambdas
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15562/5/src/kudu/client/meta_cache.cc
File src/kudu/client/meta_cache.cc:
http://gerrit.cloudera.org:8080/#/c/15562/5/src/kudu/client/meta_cache.cc@458
PS5, Line 458: [this, callback, deadline](const Status& s) {
Out of curiosity, what's your heuristic for when to use = and when to spell out the arguments? This seems morally equivalent to capturing by copy.
http://gerrit.cloudera.org:8080/#/c/15562/5/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/15562/5/src/kudu/consensus/raft_consensus.cc@2251
PS5, Line 2251: StatusCallback client_cb = std::bind(&RaftConsensus::MarkDirtyOnSuccess,
: this,
: string("Replicated consensus-only round"),
: &DoNothingStatusCB,
: std::placeholders::_1);
nit: spacing, and also why no lambda here?
--
To view, visit http://gerrit.cloudera.org:8080/15562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
Gerrit-Change-Number: 15562
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Mar 2020 04:16:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] status callback: replace Bind usage with lambdas
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15562 )
Change subject: status_callback: replace Bind usage with lambdas
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
Gerrit-Change-Number: 15562
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Mar 2020 03:50:53 +0000
Gerrit-HasComments: No
[kudu-CR] status callback: replace Bind usage with lambdas
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15562
to look at the new patch set (#5).
Change subject: status_callback: replace Bind usage with lambdas
......................................................................
status_callback: replace Bind usage with lambdas
StatusCallback was another significant user of kudu::Bind. I've removed it
in favor of StdStatusCallback, which has been renamed to StatusCallback. All
affected Bind users were converted into lambdas.
Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
---
M src/kudu/client/authz_token_cache.cc
M src/kudu/client/batcher.cc
M src/kudu/client/client-internal.cc
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/meta_cache.cc
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_cache-test.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/master/sentry_privileges_fetcher.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/thrift/client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/async_util-test.cc
M src/kudu/util/async_util.h
M src/kudu/util/net/dns_resolver.cc
M src/kudu/util/status_callback.h
30 files changed, 133 insertions(+), 161 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/15562/5
--
To view, visit http://gerrit.cloudera.org:8080/15562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
Gerrit-Change-Number: 15562
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] status callback: replace Bind usage with lambdas
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15562 )
Change subject: status_callback: replace Bind usage with lambdas
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15562/4/src/kudu/tablet/tablet_bootstrap.cc
File src/kudu/tablet/tablet_bootstrap.cc:
http://gerrit.cloudera.org:8080/#/c/15562/4/src/kudu/tablet/tablet_bootstrap.cc@532
PS4, Line 532: make_scoped_refptr
> Is scoped_refptr has some crucial properties that required in this context,
FlushInflightstoLogCallback inherits from RefCountedThreadSafe, so as written, it is designed to be used with scoped_refptr.
I could change that, but it seems out of scope of this patch.
http://gerrit.cloudera.org:8080/#/c/15562/4/src/kudu/util/net/dns_resolver.cc
File src/kudu/util/net/dns_resolver.cc:
http://gerrit.cloudera.org:8080/#/c/15562/4/src/kudu/util/net/dns_resolver.cc@86
PS4, Line 86: Status::OK()
> nit here and elsewhere: maybe it's worth creating Status::OK() object just
I don't really see the value; Status::OK() calls the default constructor, which just zeroes a pointer.
Besides, it's out of scope of this patch, whose goal was to just change the callbacks.
--
To view, visit http://gerrit.cloudera.org:8080/15562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
Gerrit-Change-Number: 15562
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Mar 2020 00:56:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] status callback: replace Bind usage with lambdas
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15562 )
Change subject: status_callback: replace Bind usage with lambdas
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15562/5/src/kudu/client/meta_cache.cc
File src/kudu/client/meta_cache.cc:
http://gerrit.cloudera.org:8080/#/c/15562/5/src/kudu/client/meta_cache.cc@458
PS5, Line 458: [this, callback, deadline](const Status& s) {
> Out of curiosity, what's your heuristic for when to use = and when to spell
See https://google.github.io/styleguide/cppguide.html#Lambda_expressions. In particular:
Prefer explicit captures if the lambda may escape the current scope.
And:
Use default capture by value ([=]) only as a means of binding a few variables for a short lambda, where the set of captured variables is obvious at a glance. Prefer not to write long or complex lambdas with default capture by value.
In this case I guess you could go either way, but since the lambda escapes the current scope I prefer to be conservative and explicitly list the captured arguments. It's also more robust (i.e. if someone adds a new local to this function in the future, it won't automatically get captured).
http://gerrit.cloudera.org:8080/#/c/15562/5/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/15562/5/src/kudu/consensus/raft_consensus.cc@2251
PS5, Line 2251: StatusCallback client_cb = std::bind(&RaftConsensus::MarkDirtyOnSuccess,
: this,
: string("Replicated consensus-only round"),
: &DoNothingStatusCB,
: std::placeholders::_1);
> nit: spacing, and also why no lambda here?
Oh, we'll definitely lambda here, but not in the scope of this patch, which was all about eliminating usage of kudu::Bind.
Since Alexey gave me a +2 already, I'll submit this as-is and fix the spacing in a future patch (i.e. the one that'll replace std::bind with lambdas).
--
To view, visit http://gerrit.cloudera.org:8080/15562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
Gerrit-Change-Number: 15562
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Mar 2020 06:32:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] status callback: replace Bind usage with lambdas
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15562
to look at the new patch set (#3).
Change subject: status_callback: replace Bind usage with lambdas
......................................................................
status_callback: replace Bind usage with lambdas
StatusCallback was another significant user of kudu::Bind. I've removed it
in favor of StdStatusCallback, which has been renamed to StatusCallback. All
affected Bind users were converted into lambdas.
Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
---
M src/kudu/client/authz_token_cache.cc
M src/kudu/client/batcher.cc
M src/kudu/client/client-internal.cc
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/meta_cache.cc
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_cache-test.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/master/sentry_privileges_fetcher.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/thrift/client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/async_util-test.cc
M src/kudu/util/async_util.h
M src/kudu/util/net/dns_resolver.cc
M src/kudu/util/status_callback.h
30 files changed, 133 insertions(+), 161 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/15562/3
--
To view, visit http://gerrit.cloudera.org:8080/15562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
Gerrit-Change-Number: 15562
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] status callback: replace Bind usage with lambdas
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15562 )
Change subject: status_callback: replace Bind usage with lambdas
......................................................................
status_callback: replace Bind usage with lambdas
StatusCallback was another significant user of kudu::Bind. I've removed it
in favor of StdStatusCallback, which has been renamed to StatusCallback. All
affected Bind users were converted into lambdas.
Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
Reviewed-on: http://gerrit.cloudera.org:8080/15562
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/client/authz_token_cache.cc
M src/kudu/client/batcher.cc
M src/kudu/client/client-internal.cc
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/meta_cache.cc
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_cache-test.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/master/sentry_privileges_fetcher.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/thrift/client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/async_util-test.cc
M src/kudu/util/async_util.h
M src/kudu/util/net/dns_resolver.cc
M src/kudu/util/status_callback.h
30 files changed, 133 insertions(+), 161 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
Andrew Wong: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/15562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
Gerrit-Change-Number: 15562
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] status callback: replace Bind usage with lambdas
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15562 )
Change subject: status_callback: replace Bind usage with lambdas
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15562/4/src/kudu/tablet/tablet_bootstrap.cc
File src/kudu/tablet/tablet_bootstrap.cc:
http://gerrit.cloudera.org:8080/#/c/15562/4/src/kudu/tablet/tablet_bootstrap.cc@532
PS4, Line 532: make_scoped_refptr
Is scoped_refptr has some crucial properties that required in this context, or it might be possible to switch to shared_ptr?
http://gerrit.cloudera.org:8080/#/c/15562/4/src/kudu/util/net/dns_resolver.cc
File src/kudu/util/net/dns_resolver.cc:
http://gerrit.cloudera.org:8080/#/c/15562/4/src/kudu/util/net/dns_resolver.cc@86
PS4, Line 86: Status::OK()
nit here and elsewhere: maybe it's worth creating Status::OK() object just once in the scope of this method, and then use the object to invoke the callback:
static const Status kStatusOK = Status::OK();
...
return cb(kStatusOK);
?
--
To view, visit http://gerrit.cloudera.org:8080/15562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66e90b8144b2a6b03b1e102dd4ca93f8e232b1a9
Gerrit-Change-Number: 15562
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Mar 2020 00:35:14 +0000
Gerrit-HasComments: Yes