[impala] 03/05: IMPALA-8603: remove confusing logging from custom cluster tests

[lv...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lv pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit f6d40b37c8b13131cbc75db6a7327c34bf0c5a34
Author: Thomas Tauber-Marshall <tm...@cloudera.com>
AuthorDate: Mon Jun 3 15:12:37 2019 -0700

    IMPALA-8603: remove confusing logging from custom cluster tests
    
    IMPALA-1653 added explicit closing of the HS2 session that is created
    by ImpalaTestSuite during teardown. For the custom cluster tests, this
    sometimes fails, either because the impalad was shutdown and is no
    longer reachable or because it was restarted and the new impalad
    doesn't know about the session that was created before restart.
    
    Currently, when these errors occur we log them. However, this is
    confusing because several custom cluster tests now log errors even
    though they succeed. This patch changes this to simply ignore the
    errors.
    
    One concern is that a test may hit a genuine error here and if so we
    won't have the logging for it. If this happens, though, it should
    generally be possible for a dev to repro the error with the logging
    enabled.
    
    Change-Id: I96144fdbe6cc9bf0f01a9951420ee6f281fa6649
    Reviewed-on: http://gerrit.cloudera.org:8080/13502
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/common/impala_connection.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/common/impala_connection.py b/tests/common/impala_connection.py
index b05478f..5242090 100644
--- a/tests/common/impala_connection.py
+++ b/tests/common/impala_connection.py
@@ -283,7 +283,7 @@ class ImpylaHS2Connection(ImpalaConnection):
       self.__cursor.close()
     except Exception, e:
       # The session may no longer be valid if the impalad was restarted during the test.
-      LOG.exception(e)
+      pass
     self.__impyla_conn.close()
 
   def close_query(self, operation_handle):