[GitHub] [accumulo] ctubbsii opened a new issue #1740: VolumeManagerImpl proxying convenience methods around Volume/FileSystem operations need reviewed

[GitBox <gi...@apache.org>]

ctubbsii opened a new issue #1740:
URL: https://github.com/apache/accumulo/issues/1740


   The VolumeManager interface has a bunch of convenience methods, like `delete` and `create` and `globStatus` that perform the same operation on the underlying Volumes that it manages. However, these behave inconsistently, and are used inconsistently. In some cases, calling one of these methods means we want to perform that function on *all* volumes the VolumeManager is managing. In other cases, we may want to only perform it on a specific Volume's FileSystem once. The FileSystem may already be known if the parameter is passed as a Path object or a String that represents a fully-qualified Path. In other cases, it may be arbitrarily chosen by the VolumeManager.
   
   At least one bug was found and fixed (in Tablet) in PR #1738 in the main/2.1.0-SNAPSHOT branch, pertaining to the use of globStatus. Others may exist that are similar.
   
   In many cases, the right thing to do may be to remove these proxying methods. In other cases, we may want methods renamed to be more clear, such as `deleteEverwhere(String path)` or `createAnywhere(String path)`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org