You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/06 12:16:49 UTC

[GitHub] [flink] docete opened a new pull request #10105: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

docete opened a new pull request #10105: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner
URL: https://github.com/apache/flink/pull/10105
 
 
   ## What is the purpose of the change
   
   Since [FLINK-14080](https://issues.apache.org/jira/browse/FLINK-14080) introduced an internal representation(SqlTimestamp) of TimestampType with precision. This subtask will replace current long with SqlTimestamp, and let blink planner support precision of TimestampType.
   
   ## Brief change log
   - The first commit([ee687db](https://github.com/docete/flink/commit/ee687db5db6e142fd241a54210ff45ac684b0008)) introduces setTimestamp/getTimestamp interface to TypeGetterSetters/VectorizedColumnBatch and writeTimestamp interface to BinaryWriter
   - [be1beee](https://github.com/docete/flink/commit/be1beeeaa37a5110d070bd15bd9909634a03d680) to [0b57ee3](https://github.com/docete/flink/commit/0b57ee3bb06ec2efbddaeb2ef511764ad307f722) replace current long with SqlTimestamp, and Fix all existing failure cases
   - [915064c](https://github.com/docete/flink/commit/915064cc3b1f1d506d4099d4ec1772289637c031) introduces LegacyTimestampTypeInfo and LegacyLocalDateTimeTypeInfo to represent Types.SQL_TIMESTAMP and Types.LOCAL_DATE_TIME with precision
   - [3d1de92](https://github.com/docete/flink/commit/3d1de92308358bfc6ff7dbee8b28121322315909) supports precision of Timestamp type in table source
   
   ## Verifying this change
   
   This change is already covered by existing tests and new tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services