You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Brendan Chang <bs...@mesosphere.io> on 2015/06/19 01:11:16 UTC
Re: Review Request 35335: Fixed JSON output error TaskInfo
executor_id in slave/http.cpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35335/
-----------------------------------------------------------
(Updated June 18, 2015, 11:11 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Changes
-------
Minor syntactical changes
Bugs: MESOS-2598
https://issues.apache.org/jira/browse/MESOS-2598
Repository: mesos
Description
-------
Fixed JSON output error TaskInfo executor_id in slave/http.cpp
Diffs (updated)
-----
src/slave/http.cpp bc25bdd33277dbfa30410ad081ea09f0fc39c598
src/tests/slave_tests.cpp 8709874411835c99b8900102fd014a9e28f2b208
Diff: https://reviews.apache.org/r/35335/diff/
Testing (updated)
-------
Extended SlaveEndpoint test to launch a task and check for correct executor_id in state.json.
It was difficult to mock queued_tasks for testing (see https://issues.apache.org/jira/browse/MESOS-2896), so the extension to SlaveEndpoint verifies the executor_id format for general tasks.
Thanks,
Brendan Chang
Re: Review Request 35335: Fixed JSON output error TaskInfo
executor_id in slave/http.cpp
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35335/#review88651
-----------------------------------------------------------
Ship it!
src/tests/slave_tests.cpp (line 1049)
<https://reviews.apache.org/r/35335/#comment141238>
Minor nit, we've been using braced initializer lists either with an = or as a constructor with no space in between. I'll go with = here since I think that's what you prefer given the space.
- Benjamin Hindman
On June 18, 2015, 11:11 p.m., Brendan Chang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35335/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 11:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Bugs: MESOS-2598
> https://issues.apache.org/jira/browse/MESOS-2598
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed JSON output error TaskInfo executor_id in slave/http.cpp
>
>
> Diffs
> -----
>
> src/slave/http.cpp bc25bdd33277dbfa30410ad081ea09f0fc39c598
> src/tests/slave_tests.cpp 8709874411835c99b8900102fd014a9e28f2b208
>
> Diff: https://reviews.apache.org/r/35335/diff/
>
>
> Testing
> -------
>
> Extended SlaveEndpoint test to launch a task and check for correct executor_id in state.json.
>
> It was difficult to mock queued_tasks for testing (see https://issues.apache.org/jira/browse/MESOS-2896), so the extension to SlaveEndpoint verifies the executor_id format for general tasks.
>
>
> Thanks,
>
> Brendan Chang
>
>
Re: Review Request 35335: Fixed JSON output error TaskInfo
executor_id in slave/http.cpp
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35335/#review88642
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35335]
All tests passed.
- Mesos ReviewBot
On June 18, 2015, 11:11 p.m., Brendan Chang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35335/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 11:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Bugs: MESOS-2598
> https://issues.apache.org/jira/browse/MESOS-2598
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed JSON output error TaskInfo executor_id in slave/http.cpp
>
>
> Diffs
> -----
>
> src/slave/http.cpp bc25bdd33277dbfa30410ad081ea09f0fc39c598
> src/tests/slave_tests.cpp 8709874411835c99b8900102fd014a9e28f2b208
>
> Diff: https://reviews.apache.org/r/35335/diff/
>
>
> Testing
> -------
>
> Extended SlaveEndpoint test to launch a task and check for correct executor_id in state.json.
>
> It was difficult to mock queued_tasks for testing (see https://issues.apache.org/jira/browse/MESOS-2896), so the extension to SlaveEndpoint verifies the executor_id format for general tasks.
>
>
> Thanks,
>
> Brendan Chang
>
>