You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrea Turli <no...@github.com> on 2016/09/20 14:37:49 UTC
[jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a
function (#320)
- refactor logback-test.xml
- change jsonBall to Value
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/320
-- Commit Summary --
* separate the DeploymentToVMDeployment to a function
-- File Changes --
M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/AzureComputeServiceAdapter.java (172)
A azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/functions/DeploymentToVMDeployment.java (121)
M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/Deployment.java (2)
A azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/Value.java (41)
M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/util/BlobHelper.java (6)
M azurecompute-arm/src/test/resources/logback-test.xml (64)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/320.patch
https://github.com/jclouds/jclouds-labs/pull/320.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320
Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a
function (#320)
Posted by Andrea Turli <no...@github.com>.
@andreaturli pushed 1 commit.
7b35424 fix Deployment
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320/files/817350313452bc7227c25deb0db60f0602821b68..7b354241feeb74af24199b75527b4ccb731a1a6d
Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a
function (#320)
Posted by Andrea Turli <no...@github.com>.
Closed #320.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#event-797411872
Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a
function (#320)
Posted by Ignasi Barrera <no...@github.com>.
nacx approved this pull request.
> private final ProviderMetadata providerMetadata;
+ private final DeploymentToVMDeployment deploymentToVMDeployment;
Better declare and inject it as `Function<Deployment, VMDeployment>` to make it easier to re-bind.
> @@ -288,7 +279,7 @@ public VMImage getImage(final String id) {
@Override
public Iterable<Location> listLocations() {
- final Iterable<String> whiteListZoneName = findWhiteListOfRegions();
+ final Iterable<String> whiteListedRegionNames = findWhiteListOfRegions();
You are parsing this list in several places. Just call this in the constructor and assign to a class final variable.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#pullrequestreview-960424
Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a
function (#320)
Posted by Ignasi Barrera <no...@github.com>.
Just minors. let's merge it, since I plan to open a PR with the minor fixes in a while.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248627353
Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a
function (#320)
Posted by Andrea Turli <no...@github.com>.
thx @nacx, merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/28c56e06)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248632037