You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Ron Gavlin (JIRA)" <ji...@apache.org> on 2008/10/03 15:03:52 UTC

[jira] Created: (SM-1607) JBI container should be able to initialize all SAs first and then start them

JBI container should be able to initialize all SAs first and then start them
----------------------------------------------------------------------------

                 Key: SM-1607
                 URL: https://issues.apache.org/activemq/browse/SM-1607
             Project: ServiceMix
          Issue Type: Improvement
          Components: servicemix-core
    Affects Versions: 3.2.2
            Reporter: Ron Gavlin


This issue is related to issue SM-1554

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SM-1607) JBI container should be able to initialize all SAs first and then start them

Posted by "Jamie Goodyear (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jamie Goodyear updated SM-1607:
-------------------------------

    Attachment: sm1607.txt

See attached file 'sm1607.txt'.

This is my first attempt at resolving this issue, so please review before trying this one out.

The basics of this patch includes having the Deployment Service start method internally initializes all SAs. To facilitate this the Service Assembly Life Cycle is updated to include an init method that handles initializing the assembly's SUs.

The Deployment Test is updated to accommodate a verification issue that occurs with EasyMocks during testing.

> JBI container should be able to initialize all SAs first and then start them
> ----------------------------------------------------------------------------
>
>                 Key: SM-1607
>                 URL: https://issues.apache.org/activemq/browse/SM-1607
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Ron Gavlin
>         Attachments: sm1607.txt
>
>
> This issue is related to issue SM-1554

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1607) JBI container should be able to initialize all SAs first and then start them

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47795#action_47795 ] 

Guillaume Nodet commented on SM-1607:
-------------------------------------

Two comments:
  * I think there is a problem when the SA is restored to a stopped state.  The SU will be initialized twice, once from the call to sa.init() and another one from the call to sa.restore()
  * I also think the broker should be suspended before the SA are initialized

> JBI container should be able to initialize all SAs first and then start them
> ----------------------------------------------------------------------------
>
>                 Key: SM-1607
>                 URL: https://issues.apache.org/activemq/browse/SM-1607
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Ron Gavlin
>         Attachments: sm1607.txt
>
>
> This issue is related to issue SM-1554

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SM-1607) JBI container should be able to initialize all SAs first and then start them

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved SM-1607.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 3.3.1
         Assignee: Guillaume Nodet

Sending        servicemix-core/src/main/java/org/apache/servicemix/jbi/framework/DeploymentService.java
Sending        servicemix-core/src/main/java/org/apache/servicemix/jbi/framework/ServiceAssemblyLifeCycle.java
Transmitting file data ..
Committed revision 725284.

Thanks a lot Jamie for this patch.

I haven't backported this fix to 3.2 branch because it does not make any sense.
This fix is related to the change in the endpoint lifefycle that occured in all components for 3.3, so in 3.2, endpoints are activated while SUs are started.
Therefore, the behavior would not be changed in 3.2.

> JBI container should be able to initialize all SAs first and then start them
> ----------------------------------------------------------------------------
>
>                 Key: SM-1607
>                 URL: https://issues.apache.org/activemq/browse/SM-1607
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Ron Gavlin
>            Assignee: Guillaume Nodet
>             Fix For: 3.3.1
>
>         Attachments: sm1607.txt, sm1607b.txt
>
>
> This issue is related to issue SM-1554

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SM-1607) JBI container should be able to initialize all SAs first and then start them

Posted by "Jamie Goodyear (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jamie Goodyear updated SM-1607:
-------------------------------

    Attachment: sm1607b.txt

See attached file 'sm1607b.txt'.

This is my second attempt at resolving this issue, so please review before trying this one out.

The basics of this patch includes having the Deployment Service start method internally initializes all SAs. To facilitate this the Service Assembly Life Cycle is updated to include an init method that handles initializing the assembly's SUs. 

I've included updates to handle the two issues Guillaume noted. I now suspend the broker before initializing any SAs, secondly I have modified the restore call to specify if a forceInit is required for SUs (the original behavior is maintained by restore() signature).

No modifications are required to the DeploymentTests using this patch.

> JBI container should be able to initialize all SAs first and then start them
> ----------------------------------------------------------------------------
>
>                 Key: SM-1607
>                 URL: https://issues.apache.org/activemq/browse/SM-1607
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-core
>    Affects Versions: 3.2.2
>            Reporter: Ron Gavlin
>         Attachments: sm1607.txt, sm1607b.txt
>
>
> This issue is related to issue SM-1554

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.