You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/24 21:36:43 UTC
[GitHub] [arrow-rs] thinkharderdev opened a new pull request, #2155: Implement `peek_next_page` and `skip_next_page` for `InMemoryColumnCh…
thinkharderdev opened a new pull request, #2155:
URL: https://github.com/apache/arrow-rs/pull/2155
…unkReader`
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2129 .
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2155: Implement `peek_next_page` and `skip_next_page` for `InMemoryColumnCh…
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2155:
URL: https://github.com/apache/arrow-rs/pull/2155#issuecomment-1195412504
Benchmark runs are scheduled for baseline = 37dd03756953d92bd303549fb0f7610a6d3c5c56 and contender = aeb277642d1267673055aa0f705646db96dad340. aeb277642d1267673055aa0f705646db96dad340 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/95e7aaab28714291893dd55f997f02b2...9b8c2cd5e089415badb4444ebd70324b/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/18f5d9cc417c448597f691314d8444fa...a6064d5039e94740b946e4a59fc25b2f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/669b9c15dba24f2fb14268bee5436826...ceb1de1f2e304d3e99713459ed0b0fca/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5107de1fc90c4e03b42b3b4fc56353fb...43333a56ac244b38adb080d1f6625ded/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on pull request #2155: Implement `peek_next_page` and `skip_next_page` for `InMemoryColumnCh…
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on PR #2155:
URL: https://github.com/apache/arrow-rs/pull/2155#issuecomment-1194878916
> Nice work @thinkharderdev
>
> cc @Ted-Jiang
@thinkharderdev Nice work! will review later today 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #2155: Implement `peek_next_page` and `skip_next_page` for `InMemoryColumnCh…
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2155:
URL: https://github.com/apache/arrow-rs/pull/2155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2155: Implement `peek_next_page` and `skip_next_page` for `InMemoryColumnCh…
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2155:
URL: https://github.com/apache/arrow-rs/pull/2155#discussion_r929007257
##########
parquet/src/arrow/async_reader.rs:
##########
@@ -589,11 +599,87 @@ impl PageReader for InMemoryColumnChunkReader {
}
fn peek_next_page(&mut self) -> Result<Option<PageMetadata>> {
- Err(nyi_err!("https://github.com/apache/arrow-rs/issues/1792"))
+ while self.seen_num_values < self.chunk.num_values {
+ return if let Some(buffered_header) = self.next_page_header.as_ref() {
+ match buffered_header.type_ {
Review Comment:
Perhaps we could extract this conversion into a From implementation? This would reduce code duplication in this function and potentially elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2155: Implement `peek_next_page` and `skip_next_page` for `InMemoryColumnCh…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2155:
URL: https://github.com/apache/arrow-rs/pull/2155#issuecomment-1193401557
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2155](https://codecov.io/gh/apache/arrow-rs/pull/2155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cee1ef8) into [master](https://codecov.io/gh/apache/arrow-rs/commit/1621c713d724b0cd4aabccfa3243714789283df5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1621c71) will **decrease** coverage by `0.08%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #2155 +/- ##
==========================================
- Coverage 82.85% 82.77% -0.09%
==========================================
Files 237 237
Lines 61381 61440 +59
==========================================
- Hits 50856 50854 -2
- Misses 10525 10586 +61
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/arrow/async\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/2155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXN5bmNfcmVhZGVyLnJz) | `0.00% <0.00%> (ø)` | |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/2155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `62.69% <0.00%> (-0.32%)` | :arrow_down: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/2155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.43% <0.00%> (-0.20%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (ø)` | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org