You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Paul Sutton <pa...@awe.com> on 1998/02/04 14:45:13 UTC
Re: cvs commit: apache-1.3/src/os/bs2000 os.c
On 3 Feb 1998 martin@hyperreal.org wrote:
> diff -u -u -r1.2 -r1.3
> --- os.c 1998/01/26 16:46:16 1.2
> +++ os.c 1998/02/03 16:55:30 1.3
> @@ -56,6 +56,7 @@
> * Any inlineable functions should be defined in os-inline.c instead.
> */
>
> +#include "httpd.h"
> #include "os.h"
>
> /* Check the Content-Type to decide if conversion is needed */
Hi Martin, is this really required? The os/* files should not need to know
about Apache. They can then be used in other programs (e.g. htpasswd). If
there is something in the os dir that needs to know about httpd.h or any
other Apache include file, it should probably be moved to the ap library
instead....
//pcs
Re: cvs commit: apache-1.3/src/os/bs2000 os.c
Posted by Martin Kraemer <Ma...@mch.sni.de>.
On Wed, Feb 04, 1998 at 01:45:13PM +0000, Paul Sutton wrote:
> > +#include "httpd.h"
>
> Hi Martin, is this really required? The os/* files should not need to know
> about Apache. They can then be used in other programs (e.g. htpasswd).
Hmm... I thought the EBCDIC port was "os specific" enough to be put into
os/ (the conversion stuff will hardly be used by anything else in ap).
OTOH, you're of course right, conversion is not really OS specific but
charset specific. (Maybe ap/ isn't the right repository either and we
need another charset/ or nonascii/ subdirectory).
Is it important that this be resolved before 1.3b4?
> If
> there is something in the os dir that needs to know about httpd.h or any
> other Apache include file, it should probably be moved to the ap library
> instead....
A couple of days Ken complained when I used aplog_error() in one of the
ap/ files... Nowhere to run, nowhere to go...
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request