You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/07/29 02:02:38 UTC

[lucene-solr] 05/27: @422 Enable DeleteInactiveReplicaTest.

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git

commit c5603f36f6e429096e2f99472e23c9914f3392e3
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Tue Jul 28 09:38:15 2020 -0500

    @422 Enable DeleteInactiveReplicaTest.
---
 .../src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java b/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java
index aa52b94..5d0ef75 100644
--- a/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java
@@ -39,7 +39,6 @@ import org.junit.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-@Ignore // nocommit debug
 public class DeleteInactiveReplicaTest extends SolrCloudTestCase {
 
   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
@@ -97,11 +96,6 @@ public class DeleteInactiveReplicaTest extends SolrCloudTestCase {
     cluster.startJettySolrRunner(jetty);
     log.info("restarted jetty");
 
-    // the system was down, these don't seem to get removed
-//    TimeOut timeOut = new TimeOut(10, TimeUnit.SECONDS, TimeSource.NANO_TIME);
-//    timeOut.waitFor("Expected data dir and instance dir of " + replica.getName() + " is deleted", ()
-//        -> !Files.exists(replicaCd.getInstanceDir()) && !FileUtils.fileExists(replicaCd.getDataDir()));
-
     // Check that we can't create a core with no coreNodeName
     try (SolrClient queryClient = getHttpSolrClient(jetty.getBaseUrl().toString())) {
       Exception e = expectThrows(Exception.class, () -> {
@@ -111,7 +105,7 @@ public class DeleteInactiveReplicaTest extends SolrCloudTestCase {
         createRequest.setShardId("shard2");
         queryClient.request(createRequest);
       });
-      assertTrue("Unexpected error message: " + e.getMessage(), e.getMessage().contains("coreNodeName missing"));
+      assertTrue("Unexpected error message: " + e.getMessage(), e.getMessage().contains("No coreNodeName for"));
 
     }
   }