You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Carsten Ziegeler <cz...@s-und-n.de> on 2002/07/11 08:26:44 UTC

[vote]: Applying patches

Hi Team,

I think we should vote on some patches we have in bugzilla.

I will try to apply patch 10505, [PATCH] Splitting JVM 1.3 and 1.4 Avalon
binaries,
to the 2.0.3 branch asap, in order to get the next release out by monday.

And here is the list of patches we could apply for 2.1-dev:

10284:[PATCH] CachingPoint caching algorithm
This patch seems to make sense - we already discussed it.

9075:[PATCH] Contribution of SAP R/3(r) connectivity components
Adding the possibility to access SAP from Cocoon is IMHO a very usefull
feature. Is someone already using it?

10540:[PATCH] Make CInclude support select="xpath" attribute
This patch was discussed recently - what's the status?

And now the patches I don't have information on, perhaps someone of
you could add it?
9521:[PATCH] Mozilla script support for simple-xml2html.xsl

9728:[PATCH] CocoonServlet getClassPath() enhancements Tomcat4

10208:[PATCH]/[RT] Aggregation and Error Conditions (file not foun

10411:[PATCH] upgrade POI/HSSF Serilizer to latest development rel

10429:[PATCH]ParameterSelector:new User doc, overview + examples

Carsten


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: [vote]: Applying patches

Posted by "Andrew C. Oliver" <ac...@apache.org>.
>
>
>10540:[PATCH] Make CInclude support select="xpath" attribute
>This patch was discussed recently - what's the status?
>  
>
new patch is ready (apply the latest and not the earlier versions)  fire 
away.


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


RE: [vote]: Applying patches

Posted by Carsten Ziegeler <cz...@s-und-n.de>.
Reinhard Poetz wrote:
> 
> As Michael Gerzabek and I are the committers of this patch some words:
> Yes, we are already using it successfully at some of our customers :-)

Great!

> 
> There remains only one problem:
> -------------------------------
> In order to build our sources, JCo.jar (SAP Java Connector) is absolutly 
> necessary. As JCo.jar is copyright-protected by SAP I can only offer 
> following 'workaround':
> 
> - case1: JCo.jar is not available
>   --> during the build of Cocoon our prebuild web3-core.jar is taken
>       and the source files are ignored
> 
> - case2: JCo.jar is available
>   --> during the build of Cocoon our prebuild web3-core.jar is ignored
>       and the source files are compiled
> 
> 
> What do you think? Is it an acceptable solution?
> 
I suggest to follow the procedure all other optional components use:
- There is no prebuild jar
- The build system checks, if the required jar (JCo.jar) is available.
  Only if this is the case, the source is compiled

This is done for many components, for example the xmldb stuff or
batik etc.

If you need any help here, I can setup the build system for you.

> Regards,
> Reinhard
> 
> PS: We improved some of the classes. If you like to include the 
> connectivity-tool (web3-core) we will provide the new patch.
> 
Sounds good! Yes, a new patch would be good, perhaps together
with the above mentioned changes ? ;)

Regards
Carsten

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


RE: [vote]: Applying patches

Posted by Reinhard Poetz <re...@gmx.net>.
> >> 9075:[PATCH] Contribution of SAP R/3(r) connectivity components
> >> Adding the possibility to access SAP from Cocoon is IMHO a very 
> >> usefull feature. Is someone already using it?
> >
> >
> > +1

As Michael Gerzabek and I are the committers of this patch some words:
Yes, we are already using it successfully at some of our customers :-)

- the example comes with it's own sub-sitemap
- we will add a 'welcome'-page with some instructions how you can
  set up  a connection to an SAP-R/3-system
  - add JCo.jar (available at http://service.sap.com/connectors -->
    if you have a SAP-system you have access to this site)
  - enter the correct logon-parameters in the configuration file

  --> that's it

There was a question: "What happens if there is any SAP-system available?"

  --> As long as you only watch the welcome-page and don't click on
      the example - nothing

  --> The connection to SAP-R/3 is established at the first time you
      call a pipeline using our RFC-transformer


There remains only one problem:
-------------------------------
In order to build our sources, JCo.jar (SAP Java Connector) is absolutly 
necessary. As JCo.jar is copyright-protected by SAP I can only offer 
following 'workaround':

- case1: JCo.jar is not available
  --> during the build of Cocoon our prebuild web3-core.jar is taken
      and the source files are ignored

- case2: JCo.jar is available
  --> during the build of Cocoon our prebuild web3-core.jar is ignored
      and the source files are compiled


What do you think? Is it an acceptable solution?

Regards,
Reinhard

PS: We improved some of the classes. If you like to include the 
connectivity-tool (web3-core) we will provide the new patch.






---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: [vote]: Applying patches

Posted by Michael Melhem <mi...@fztig938.bank.dresdner.net>.

On Thu, 11 Jul 2002, Sylvain Wallez wrote:

> Nicola Ken Barozzi wrote:
>
> > Carsten Ziegeler wrote:
> >
> >> Hi Team,
> >>
> >> I think we should vote on some patches we have in bugzilla.
> >
> >
> > Thanks Carsten, we need this :-)
> >
>
> >> And here is the list of patches we could apply for 2.1-dev:
> >>
> >> 10284:[PATCH] CachingPoint caching algorithm
> >> This patch seems to make sense - we already discussed it.
> >
> >
> > +1
> >
>
> +1. What about my proposal about explicitely defining cache points in
> the sitemap ?

Yes,  I can see cases where explicit cache points might be useful. Once the above patch is applied....it can be easly extended to handle explicit cache points..if we decide to go down that path.

Regrards,
Michael Melhem
>
>
> --
> Sylvain Wallez
>   Anyware Technologies                  Apache Cocoon
>   http://www.anyware-tech.com           mailto:sylvain@apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: [vote]: Applying patches

Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Nicola Ken Barozzi wrote:

> Carsten Ziegeler wrote:
>
>> Hi Team,
>>
>> I think we should vote on some patches we have in bugzilla.
>
>
> Thanks Carsten, we need this :-)
>
>> I will try to apply patch 10505, [PATCH] Splitting JVM 1.3 and 1.4 
>> Avalon binaries, to the 2.0.3 branch asap, in order to get the next 
>> release out by monday.
>
>
> :-D


+1000

>> And here is the list of patches we could apply for 2.1-dev:
>>
>> 10284:[PATCH] CachingPoint caching algorithm
>> This patch seems to make sense - we already discussed it.
>
>
> +1
>

+1. What about my proposal about explicitely defining cache points in 
the sitemap ?

>> 9075:[PATCH] Contribution of SAP R/3(r) connectivity components
>> Adding the possibility to access SAP from Cocoon is IMHO a very 
>> usefull feature. Is someone already using it?
>
>
> +1


+1, even if not using. It's also great from the Cocoon marketing POV.

>> 10540:[PATCH] Make CInclude support select="xpath" attribute
>> This patch was discussed recently - what's the status?
>
>
> +0


-0. What about having a good XInclude and deprecate CInclude ?

>> And now the patches I don't have information on, perhaps someone of 
>> you could add it?
>> 9521:[PATCH] Mozilla script support for simple-xml2html.xsl
>
>
> +1 it makes the prettydocs view better for mozilla


+1

>> 9728:[PATCH] CocoonServlet getClassPath() enhancements Tomcat4
>
>
> It changes classpath behaviour, -1
> I'd be +0 if it's possible to enable it via config.


-0.5, as it is too much Tomcat-specific and AFAIK, we don't have 
classpath problems on Tomcat.

>> 10208:[PATCH]/[RT] Aggregation and Error Conditions (file not foun
>
>
> +1


Don't know

>> 10411:[PATCH] upgrade POI/HSSF Serilizer to latest development rel
>
>
> +1


+1

>> 10429:[PATCH]ParameterSelector:new User doc, overview + examples
>
>
> +1 with docs review


+1

> You forgot:
>
> 8614  Enh Oth All cocoon-dev@xml.apache.org NEW  [PATCH] configurable 
> component manager
>
> +1 


+1

> 6879  Enh Oth All g-froehlich@gmx.de NEW  [PATCH] Cache improvement 
> using ESI invalidation protocol
>
> abstain


-1. Comments on the patch show that this patch requires more thinking.

Sylvain

-- 
Sylvain Wallez
  Anyware Technologies                  Apache Cocoon
  http://www.anyware-tech.com           mailto:sylvain@apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: [vote]: Applying patches

Posted by Stephan Michels <st...@apache.org>.
On Thu, 11 Jul 2002, Nicola Ken Barozzi wrote:

> Carsten Ziegeler wrote:
> > Hi Team,
> >
> > I think we should vote on some patches we have in bugzilla.
>
> Thanks Carsten, we need this :-)
>
> > I will try to apply patch 10505, [PATCH] Splitting JVM 1.3 and 1.4 Avalon
> > binaries,
> > to the 2.0.3 branch asap, in order to get the next release out by monday.
>
> :-D

+1

> > And here is the list of patches we could apply for 2.1-dev:
> >
> > 10284:[PATCH] CachingPoint caching algorithm
> > This patch seems to make sense - we already discussed it.
>
> +1

+0

>
> > 9075:[PATCH] Contribution of SAP R/3(r) connectivity components
> > Adding the possibility to access SAP from Cocoon is IMHO a very usefull
> > feature. Is someone already using it?
>
> +1

-0. Does these components also work, if the SAP doesn't exits? Perhaps
there should be a condition in the build.xml.

> > 10540:[PATCH] Make CInclude support select="xpath" attribute
> > This patch was discussed recently - what's the status?
>
> +0

+1. That makes really sense. But the CachingCInclude should also be
patched, and also the docs ;-)

> > And now the patches I don't have information on, perhaps someone of
> > you could add it?
> > 9521:[PATCH] Mozilla script support for simple-xml2html.xsl
>
> +1 it makes the prettydocs view better for mozilla

+1. Mozilla is my default browser.

> > 9728:[PATCH] CocoonServlet getClassPath() enhancements Tomcat4
>
> It changes classpath behaviour, -1
> I'd be +0 if it's possible to enable it via config.
>
> > 10208:[PATCH]/[RT] Aggregation and Error Conditions (file not foun
>
> +1

+0

> > 10411:[PATCH] upgrade POI/HSSF Serilizer to latest development rel
>
> +1

+0

> > 10429:[PATCH]ParameterSelector:new User doc, overview + examples
>
> +1 with docs review

+0

> You forgot:
>
> 8614  Enh Oth All cocoon-dev@xml.apache.org NEW  [PATCH] configurable
> component manager
>
> +1

+0

> 6879  Enh Oth All g-froehlich@gmx.de NEW  [PATCH] Cache improvement
> using ESI invalidation protocol
>
> abstain

+0


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: [vote]: Applying patches

Posted by Nicola Ken Barozzi <ni...@apache.org>.
Carsten Ziegeler wrote:
> Hi Team,
> 
> I think we should vote on some patches we have in bugzilla.

Thanks Carsten, we need this :-)

> I will try to apply patch 10505, [PATCH] Splitting JVM 1.3 and 1.4 Avalon
> binaries,
> to the 2.0.3 branch asap, in order to get the next release out by monday.

:-D

> And here is the list of patches we could apply for 2.1-dev:
> 
> 10284:[PATCH] CachingPoint caching algorithm
> This patch seems to make sense - we already discussed it.

+1


> 9075:[PATCH] Contribution of SAP R/3(r) connectivity components
> Adding the possibility to access SAP from Cocoon is IMHO a very usefull
> feature. Is someone already using it?

+1

> 10540:[PATCH] Make CInclude support select="xpath" attribute
> This patch was discussed recently - what's the status?

+0

> And now the patches I don't have information on, perhaps someone of
> you could add it?
> 9521:[PATCH] Mozilla script support for simple-xml2html.xsl

+1 it makes the prettydocs view better for mozilla

> 9728:[PATCH] CocoonServlet getClassPath() enhancements Tomcat4

It changes classpath behaviour, -1
I'd be +0 if it's possible to enable it via config.

> 10208:[PATCH]/[RT] Aggregation and Error Conditions (file not foun

+1

> 10411:[PATCH] upgrade POI/HSSF Serilizer to latest development rel

+1

> 10429:[PATCH]ParameterSelector:new User doc, overview + examples

+1 with docs review

You forgot:

8614  Enh Oth All cocoon-dev@xml.apache.org NEW  [PATCH] configurable 
component manager

+1

6879  Enh Oth All g-froehlich@gmx.de NEW  [PATCH] Cache improvement 
using ESI invalidation protocol

abstain


-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: [vote]: Applying patches

Posted by "Andrew C. Oliver" <ac...@apache.org>.
>
>
>10540:[PATCH] Make CInclude support select="xpath" attribute
>This patch was discussed recently - what's the status?
>  
>
status is:

I'm going to submit another patch (hopefully tonight - current day time 
is "morning") which makes the
if statement a bit more clear.  (There was no else, and it was 
questioned, it functions as intended but
if it was questioned, then its not clear ;-) and I'm a code quality nut 
;-) )

Once thats done, this is definitely a 2.1 and not a 2.0.3

Following the application of this patch, I'll submit another patch (as 
time permits) which combines the
CInclude and XInclude code-bases.  I'll use CInclude as the basis as it 
seems to be better (and more
efficient) code in my opinion, while making it operate on the XInclude 
namespace as well.

>10411:[PATCH] upgrade POI/HSSF Serilizer to latest development rel
>  
>
+1 (I inteded this for 2.1 and not 2.0.3)

>10429:[PATCH]ParameterSelector:new User doc, overview + examples
>
>Carsten
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
>For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
>  
>




---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: [vote]: Applying patches

Posted by Ivelin Ivanov <iv...@apache.org>.
From: "Carsten Ziegeler" <cz...@s-und-n.de>
> Hi Team,
>
> I think we should vote on some patches we have in bugzilla.
>
> 10540:[PATCH] Make CInclude support select="xpath" attribute
> This patch was discussed recently - what's the status?

This patch makes sence. Andy is merging CInclude and XInclude as we
discussed before. Same code base, but support for 2 namespaces : W3C
XInclude and the cocoon/cinclude.
I plan to apply it, although still having problems getting 2.1 working.

Can get past this error, when trying to access any page:

ERROR   (2002-07-06) 15:48.53:878   [sitemap] (/cocoon/samples/welcome)
HttpProcessor[8080][4]/PipelineNode: Error while processing pipeline at
file:/D:/cvs/xml-cocoon2/src/webapp/samples/sitemap.xmap:223:17
org.apache.cocoon.ProcessingException: Lookup of transformer for role 'xslt'
failed.: org.apache.avalon.framework.component.ComponentException:
UnnamedSelector: ComponentSelector could not find the component for hint:
xslt
 at
 at
org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.addTransfor
mer(AbstractProcessingPipeline.java:270)





Ivelin




---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: [vote]: Applying patches

Posted by Diana Shannon <sh...@apache.org>.
On Thursday, July 11, 2002, at 02:26  AM, Carsten Ziegeler wrote:

> Hi Team,
>
> I think we should vote on some patches we have in bugzilla.
>
> And here is the list of patches we could apply for 2.1-dev:
>

>
> 10429:[PATCH]ParameterSelector:new User doc, overview + examples

Already applied against 2.1-dev and 2.0.3 yesterday. Sorry, I forgot to 
close it in Bugzilla.

Diana


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org