You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "izveigor (via GitHub)" <gi...@apache.org> on 2023/04/03 08:34:56 UTC
[GitHub] [arrow-datafusion] izveigor opened a new pull request, #5839: feat: BuiltinScalarFunction::Cbrt
izveigor opened a new pull request, #5839:
URL: https://github.com/apache/arrow-datafusion/pull/5839
# Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/5838
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
Yes
# Are there any user-facing changes?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5839: feat: BuiltinScalarFunction::Cbrt
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5839:
URL: https://github.com/apache/arrow-datafusion/pull/5839#issuecomment-1497433760
Thanks again @izveigor and @yjshen !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] izveigor commented on a diff in pull request #5839: feat: BuiltinScalarFunction::Cbrt
Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor commented on code in PR #5839:
URL: https://github.com/apache/arrow-datafusion/pull/5839#discussion_r1158348186
##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -1629,6 +1630,19 @@ async fn csv_query_sqrt_sqrt() -> Result<()> {
Ok(())
}
+// this query used to deadlock due to the call udf(udf())
Review Comment:
Yes, forgot to remove this docstring after pasting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5839: feat: BuiltinScalarFunction::Cbrt
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5839:
URL: https://github.com/apache/arrow-datafusion/pull/5839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5839: feat: BuiltinScalarFunction::Cbrt
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5839:
URL: https://github.com/apache/arrow-datafusion/pull/5839#discussion_r1157782560
##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -1629,6 +1630,19 @@ async fn csv_query_sqrt_sqrt() -> Result<()> {
Ok(())
}
+// this query used to deadlock due to the call udf(udf())
Review Comment:
```suggestion
```
Perhaps it was a left over from a copy / paste?
What do you think @izveigor ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5839: feat: BuiltinScalarFunction::Cbrt
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5839:
URL: https://github.com/apache/arrow-datafusion/pull/5839#discussion_r1156131247
##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -1629,6 +1630,19 @@ async fn csv_query_sqrt_sqrt() -> Result<()> {
Ok(())
}
+// this query used to deadlock due to the call udf(udf())
Review Comment:
I don't understand this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org