You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2021/06/10 09:36:28 UTC
[GitHub] [fluo-muchos] arvindshmicrosoft opened a new pull request #397: Make Azure data disk config names consistent
arvindshmicrosoft opened a new pull request #397:
URL: https://github.com/apache/fluo-muchos/pull/397
* Use the `data_disk` prefix consistently across single-VMSS and
multiple-VMSS configurations in Azure
* Consistently specify OS disk SKU, and disk caching across VMSS types
* Remove the hard-coded Azure VM SKU for the proxy host
* Update Azure multiple VMSS doc and sample config files accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #397: Make Azure data disk config names consistent
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #397:
URL: https://github.com/apache/fluo-muchos/pull/397#discussion_r649493228
##########
File path: docs/azure-multiple-vmss.md
##########
@@ -27,7 +27,7 @@ Muchos provides a [sample file](../conf/azure_multiple_vmss_vars.yml.example) wh
| `azure_disk_device_pattern`| Optional | If not specified, the corresponding `azure_disk_device_pattern` value from the `azure` section in [muchos.props](../conf/muchos.props.example) is used | This is a device name wildcard pattern used (internally) in conjunction with `azure_disk_device_path` to enumerate attached SCSI or NVME disks to use for persistent local storage |
| `mount_root`| Optional | If not specified, the corresponding `mount_root` value from the `azure` section in [muchos.props](../conf/muchos.props.example) is used | This is the folder in the file system where the persistent disks are mounted |
| `data_disk_count`| Required | - | An integer value which specifies the number of persistent (managed) data disks to be attached to each VM in the VMSS. It can be 0 in specific cases - see [notes on using ephemeral storage](./azure-ephemeral-disks.md) for details |
-| `disk_sku`| Required | - | Can be either Standard_LRS (for HDD) or Premium_LRS (for Premium SSD). At this time, we have not tested the use of Standard SSD or UltraSSD with Muchos |
+| `data_disk_sku`| Required | - | Can be either Standard_LRS (for HDD) or Premium_LRS (for Premium SSD). At this time, we have not tested the use of Standard SSD or UltraSSD with Muchos |
Review comment:
Should osdisk_sku also have an entry in this table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #397: Make Azure data disk config names consistent
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #397:
URL: https://github.com/apache/fluo-muchos/pull/397#discussion_r650116178
##########
File path: lib/muchos/config/azure.py
##########
@@ -297,15 +297,15 @@ def azure_proxy_host(self):
return self.get("azure", "azure_proxy_host")
@ansible_host_var
- @default(None)
+ @default("Standard_D8s_v3")
def azure_proxy_host_vm_sku(self):
return self.get("azure", "azure_proxy_host_vm_sku")
Review comment:
Done, addressed in [17babc8](https://github.com/apache/fluo-muchos/pull/397/commits/17babc80c41d917735188f74aed8e9ebad10a79e). I am going to resolve this conversation as I know you are out of office currently and we chatted offline about this.
##########
File path: lib/muchos/config/azure.py
##########
@@ -297,15 +297,15 @@ def azure_proxy_host(self):
return self.get("azure", "azure_proxy_host")
@ansible_host_var
- @default(None)
+ @default("Standard_D8s_v3")
def azure_proxy_host_vm_sku(self):
return self.get("azure", "azure_proxy_host_vm_sku")
Review comment:
Done, addressed in [17babc8](https://github.com/apache/fluo-muchos/pull/397/commits/17babc80c41d917735188f74aed8e9ebad10a79e). I am going to resolve this conversation as I know you are out of office currently and we chatted offline about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #397: Make Azure data disk config names consistent
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #397:
URL: https://github.com/apache/fluo-muchos/pull/397#discussion_r649885295
##########
File path: lib/muchos/config/azure.py
##########
@@ -297,15 +297,15 @@ def azure_proxy_host(self):
return self.get("azure", "azure_proxy_host")
@ansible_host_var
- @default(None)
+ @default("Standard_D8s_v3")
def azure_proxy_host_vm_sku(self):
return self.get("azure", "azure_proxy_host_vm_sku")
Review comment:
Do we not want to add this property to the `muchos.props` file?
##########
File path: lib/muchos/config/azure.py
##########
@@ -297,15 +297,15 @@ def azure_proxy_host(self):
return self.get("azure", "azure_proxy_host")
@ansible_host_var
- @default(None)
+ @default("Standard_D8s_v3")
def azure_proxy_host_vm_sku(self):
return self.get("azure", "azure_proxy_host_vm_sku")
Review comment:
Do we not want to add this property to the `muchos.props` file?
##########
File path: lib/muchos/config/azure.py
##########
@@ -297,15 +297,15 @@ def azure_proxy_host(self):
return self.get("azure", "azure_proxy_host")
@ansible_host_var
- @default(None)
+ @default("Standard_D8s_v3")
def azure_proxy_host_vm_sku(self):
return self.get("azure", "azure_proxy_host_vm_sku")
Review comment:
Do we not want to add this property to the `muchos.props.example` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft merged pull request #397: Make Azure data disk config names consistent
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft merged pull request #397:
URL: https://github.com/apache/fluo-muchos/pull/397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #397: Make Azure data disk config names consistent
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #397:
URL: https://github.com/apache/fluo-muchos/pull/397#discussion_r649557572
##########
File path: docs/azure-multiple-vmss.md
##########
@@ -27,7 +27,7 @@ Muchos provides a [sample file](../conf/azure_multiple_vmss_vars.yml.example) wh
| `azure_disk_device_pattern`| Optional | If not specified, the corresponding `azure_disk_device_pattern` value from the `azure` section in [muchos.props](../conf/muchos.props.example) is used | This is a device name wildcard pattern used (internally) in conjunction with `azure_disk_device_path` to enumerate attached SCSI or NVME disks to use for persistent local storage |
| `mount_root`| Optional | If not specified, the corresponding `mount_root` value from the `azure` section in [muchos.props](../conf/muchos.props.example) is used | This is the folder in the file system where the persistent disks are mounted |
| `data_disk_count`| Required | - | An integer value which specifies the number of persistent (managed) data disks to be attached to each VM in the VMSS. It can be 0 in specific cases - see [notes on using ephemeral storage](./azure-ephemeral-disks.md) for details |
-| `disk_sku`| Required | - | Can be either Standard_LRS (for HDD) or Premium_LRS (for Premium SSD). At this time, we have not tested the use of Standard SSD or UltraSSD with Muchos |
+| `data_disk_sku`| Required | - | Can be either Standard_LRS (for HDD) or Premium_LRS (for Premium SSD). At this time, we have not tested the use of Standard SSD or UltraSSD with Muchos |
Review comment:
Good question - `osdisk_sku` is actually just a local variable in the create_vmss*.yml playbooks. It is used for convenience to represent the jinja2 expression which decides whether (or not) the OS disk can be a Premium SSD, based on the capability of the VM to support such disks. If this clarifies, please resolve the comment, post which I will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #397: Make Azure data disk config names consistent
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #397:
URL: https://github.com/apache/fluo-muchos/pull/397#discussion_r649557572
##########
File path: docs/azure-multiple-vmss.md
##########
@@ -27,7 +27,7 @@ Muchos provides a [sample file](../conf/azure_multiple_vmss_vars.yml.example) wh
| `azure_disk_device_pattern`| Optional | If not specified, the corresponding `azure_disk_device_pattern` value from the `azure` section in [muchos.props](../conf/muchos.props.example) is used | This is a device name wildcard pattern used (internally) in conjunction with `azure_disk_device_path` to enumerate attached SCSI or NVME disks to use for persistent local storage |
| `mount_root`| Optional | If not specified, the corresponding `mount_root` value from the `azure` section in [muchos.props](../conf/muchos.props.example) is used | This is the folder in the file system where the persistent disks are mounted |
| `data_disk_count`| Required | - | An integer value which specifies the number of persistent (managed) data disks to be attached to each VM in the VMSS. It can be 0 in specific cases - see [notes on using ephemeral storage](./azure-ephemeral-disks.md) for details |
-| `disk_sku`| Required | - | Can be either Standard_LRS (for HDD) or Premium_LRS (for Premium SSD). At this time, we have not tested the use of Standard SSD or UltraSSD with Muchos |
+| `data_disk_sku`| Required | - | Can be either Standard_LRS (for HDD) or Premium_LRS (for Premium SSD). At this time, we have not tested the use of Standard SSD or UltraSSD with Muchos |
Review comment:
Good question - `osdisk_sku` is actually just a local variable in the create_vmss*.yml playbooks. It is used for convenience to represent the jinja2 expression which decides whether (or not) the OS disk can be a Premium SSD, based on the capability of the VM to support such disks. If this clarifies, please resolve the comment post which I will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org