[GitHub] [druid] jon-wei commented on pull request #9818: Directly rewrite filters on RHS join columns into LHS equivalents

[GitBox <gi...@apache.org>]

jon-wei commented on pull request #9818:
URL: https://github.com/apache/druid/pull/9818#issuecomment-624400878


   > I think it's a little hard to follow what's going on in JoinFilterAnalyzer, the class is now up to 1000+ lines, could you re-structure it into smaller classes that are linked to each other to make it a little easier to understand the dependencies / flow in the class.
   
   I definitely agree that's a good idea, I'll do that in a follow-on PR though, since I find that including such refactors in a PR together with functional changes makes it hard to identify the functional changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org