[jira] [Commented] (GIRAPH-785) Improve GraphPartitionerFactory usage

["Maja Kabiljo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803706#comment-13803706 ] 

Maja Kabiljo commented on GIRAPH-785:
-------------------------------------

Thanks Igor! Can you please put it on reviewboard, I have a few comments?

> Improve GraphPartitionerFactory usage 
> --------------------------------------
>
>                 Key: GIRAPH-785
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-785
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 1.1.0
>            Reporter: Igor Kabiljo
>            Priority: Minor
>         Attachments: partition_patch.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Usage of GraphPartitionerFactory can be improved:
> - defining custom partitioner needs extending 3 classes/interfaces, and defining multiple functions, which is more complex than needed 
> - range partitioners are randomly assigning excess, instead of having each partition/worker having 1 consecutive range
> - if maxPartitions is reached, we might be creating number of partitions that is not divisible with number of workers



--
This message was sent by Atlassian JIRA
(v6.1#6144)