[jira] [Comment Edited] (HTRACE-33) Add getUniqueLocalTraceFileName to LocalFileSpanReceiver

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264295#comment-14264295 ] 

Colin Patrick McCabe edited comment on HTRACE-33 at 1/5/15 7:45 AM:
--------------------------------------------------------------------

Looks good... a few comments:

* Instead of reading {{/proc/self/stat}}, I think we should call {{Tracer#getProcessId}} for this.  (Perhaps after moving {{Tracer#getProcessId}} to a utility class.)

* {{TestLocalFileSpanReceiver#testUniqueLocalTraceFileName}}: we should test that we can open and write to one of these files.



was (Author: cmccabe):
Looks good... a few comments:

* Instead of reading {{/proc/self/stat}}, I think we should call {{Tracer#getProcessId}} for this.  (Perhaps after moving Trace#getProcessId to a utility class.)

* {{TestLocalFileSpanReceiver#testUniqueLocalTraceFileName}}: we should test that we can open and write to one of these files.


> Add getUniqueLocalTraceFileName to LocalFileSpanReceiver
> --------------------------------------------------------
>
>                 Key: HTRACE-33
>                 URL: https://issues.apache.org/jira/browse/HTRACE-33
>             Project: HTrace
>          Issue Type: Improvement
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>            Priority: Minor
>         Attachments: HTRACE-33.001.patch
>
>
> o.a.hadoop.tracing.SpanReceiverHost#getUniqueLocalTraceFileName of Hadoop should belong to HTrace. Add it to HTrace first then remove it from Hadoop on the next bumping of HTrace version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)