You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 08:23:37 UTC
[GitHub] [airflow] chenglongyan opened a new pull request, #26584: Support Not/Equal To filter for value is None on webui
chenglongyan opened a new pull request, #26584:
URL: https://github.com/apache/airflow/pull/26584
closes: #26427
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #26584: Support Is /not Null filter for value is None on webui
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #26584:
URL: https://github.com/apache/airflow/pull/26584#discussion_r991383489
##########
airflow/www/static/js/main.js:
##########
@@ -226,10 +255,14 @@ $(document).ready(() => {
$.fn.datetimepicker.defaults.sideBySide = true;
$('.datetimepicker').datetimepicker();
+ $('.filters .select2-chosen').each((idx, el) => { filterOpSelected(el); });
Review Comment:
```suggestion
$('.filters .select2-chosen').each((idx, elem) => { filterOpSelected(elem); });
```
Looks like `el` is already defined in the file and causing linting issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chenglongyan commented on pull request #26584: Support Not/Equal To filter for value is None on webui
Posted by GitBox <gi...@apache.org>.
chenglongyan commented on PR #26584:
URL: https://github.com/apache/airflow/pull/26584#issuecomment-1256003323
Agreed, there are ambiguities...
> From a "SQL" point of view `""` (emptry string) is different to `None`, (SQL `NULL`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #26584: Support Not/Equal To filter for value is None on webui
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26584:
URL: https://github.com/apache/airflow/pull/26584#issuecomment-1255953976
From a "SQL" point of view `""` (emptry string) is different to `None`, (SQL `NULL`). As you've written your patch it's not possible to find values with an empty string.
Is it worth adding two extra filters for "is null" and "is not null"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #26584: Support Is /not Null filter for value is None on webui
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #26584:
URL: https://github.com/apache/airflow/pull/26584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26584: Support Not/Equal To filter for value is None on webui
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26584:
URL: https://github.com/apache/airflow/pull/26584#issuecomment-1255265873
looks like some tests are failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #26584: Support Is /not Null filter for value is None on webui
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #26584:
URL: https://github.com/apache/airflow/pull/26584#discussion_r991383489
##########
airflow/www/static/js/main.js:
##########
@@ -226,10 +255,14 @@ $(document).ready(() => {
$.fn.datetimepicker.defaults.sideBySide = true;
$('.datetimepicker').datetimepicker();
+ $('.filters .select2-chosen').each((idx, el) => { filterOpSelected(el); });
Review Comment:
```suggestion
$('.filters .select2-chosen').each((idx, e) => { filterOpSelected(e); });
```
Looks like `el` is already defined in the file and causing linting issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org