You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 17:34:57 UTC
[GitHub] [airflow] kaxil opened a new pull request #11313: Bump tenacity to 6.2
kaxil opened a new pull request #11313:
URL: https://github.com/apache/airflow/pull/11313
There is no reason to limit tenacity. One of my upcoming PRs (or a commit in scheduler-ha repo) will use a new feature available in the newer version.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704442769
why did we limit it in the first place? something must have broken with 5.1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704441358
@kaxil -> I would like to check if this works - do not merge it please before I take a look. I have a feeling we have some problem with upgrading constraints and I would like to have closer look tomorrow on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704448628
Also, no there is no reason it was pinned, apparently I did that one too: https://github.com/apache/airflow/commit/926aa1ba3a6ee8eec7b8efca2cc7f03d347134b7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704446918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704445911
I think @kaxil wants to update constraints. But I am afraid it will not work this way. I will take a look at this thing tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704446918
No no my intention is to increase the limit too, constraints is just the by-product which will help in the next OR that will use the feature from latest version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704442769
why did we limit it in the first place? something must have broken with 5.2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704445911
I think @kaxil want to update constraints. But I am afraid it will not work this way. I will take a look at this thing tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704448628
> why did we limit it in the first place? something must have broken with 5.2?
@ashb
No there is no reason it was pinned, apparently, I did that one too: https://github.com/apache/airflow/commit/926aa1ba3a6ee8eec7b8efca2cc7f03d347134b7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704459468
Just to be clear, I want to update requirements not just constraints. Constraints is the by-product. I am familiar with the current CI problem regarding constraints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil removed a comment on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
kaxil removed a comment on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704448975
@potiuk I don't see what changes yoh requested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11313:
URL: https://github.com/apache/airflow/pull/11313#issuecomment-704448975
@potiuk I don't see what changes yoh requested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11313: Bump tenacity to 6.2
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11313:
URL: https://github.com/apache/airflow/pull/11313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org