You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2016/03/15 12:36:56 UTC
Review Request 44846: Deprecated the plain text credential format.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/
-----------------------------------------------------------
Review request for mesos, Adam B and Joerg Schad.
Bugs: MESOS-2281
https://issues.apache.org/jira/browse/MESOS-2281
Repository: mesos
Description
-------
See summary
Diffs
-----
CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
Diff: https://reviews.apache.org/r/44846/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review123641
-----------------------------------------------------------
And as we changed the flags we should most likely also update configuration.md. :-)
- Joerg Schad
On March 15, 2016, 11:36 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 11:36 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review123642
-----------------------------------------------------------
src/master/flags.cpp (line 224)
<https://reviews.apache.org/r/44846/#comment185867>
s/credantials/credentials...
src/master/flags.cpp (line 225)
<https://reviews.apache.org/r/44846/#comment185868>
s/ or / or (deprecated)
src/master/flags.cpp (line 227)
<https://reviews.apache.org/r/44846/#comment185869>
Note that the plain text file format is deprecated.
src/master/flags.cpp (line 239)
<https://reviews.apache.org/r/44846/#comment185873>
IMO we could even drop this example...
src/slave/flags.cpp (line 431)
<https://reviews.apache.org/r/44846/#comment185870>
why not JSON formated credential?
src/slave/flags.cpp (line 432)
<https://reviews.apache.org/r/44846/#comment185871>
or (deprecated)
src/slave/flags.cpp (line 434)
<https://reviews.apache.org/r/44846/#comment185872>
see above.
- Joerg Schad
On March 15, 2016, 11:36 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 11:36 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On March 17, 2016, 6:21 p.m., Joerg Schad wrote:
> > src/master/flags.cpp, line 227
> > <https://reviews.apache.org/r/44846/diff/2/?file=1299753#file1299753line227>
> >
> > We now mention deprecated twice here.
> > The 'Note that' also seems to be out of sync with the configuration.md.
The whole sentence will be removed, as per Adam's comments below the deprecated format won't be mentioned at all.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review124051
-----------------------------------------------------------
On March 15, 2016, 3:01 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 3:01 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Deprecated the plain text credential format.
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b
> docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review124051
-----------------------------------------------------------
Fix it, then Ship it!
Could you please check that all the markdown files are rendered correctly by either using the rakefile and/or the docker website generator?
src/credentials/credentials.hpp (line 104)
<https://reviews.apache.org/r/44846/#comment186397>
Shouldn't this go to line 114?
src/master/flags.cpp (line 227)
<https://reviews.apache.org/r/44846/#comment186399>
We now mention deprecated twice here.
The 'Note that' also seems to be out of sync with the configuration.md.
- Joerg Schad
On March 15, 2016, 2:01 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 2:01 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Deprecated the plain text credential format.
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b
> docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review125393
-----------------------------------------------------------
Fix it, then Ship it!
Looks great. I'll fix up these last bits and commit it.
CHANGELOG (lines 5 - 9)
<https://reviews.apache.org/r/44846/#comment188179>
We like to put these in numerical order.
docs/configuration.md (lines 990 - 991)
<https://reviews.apache.org/r/44846/#comment188180>
The strings in configuration.md should match the strings in flags.cpp. Looks like this one didn't get updated with the most recent rewording.
- Adam B
On March 24, 2016, 6:22 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 6:22 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Deprecated the plain text credential format.
>
>
> Diffs
> -----
>
> CHANGELOG 1fadaa1819c9b1a801752b1c0ddd572b82e6c170
> docs/authentication.md 9f64f657d1a01f85f0132cb7264e2b85d0d3dc59
> docs/configuration.md 70686adeca239b5962652a17661c8b0d44ca6708
> docs/upgrades.md 85d02929b58b465f22d0e9991f6cf66f52b6d9a6
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp 9b65dee02e3505f22aaa967899903f80fe0e7c57
> src/slave/flags.cpp 71685cee58322e608139f7c344c2e954f7e14322
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
> Created the documentation using the Dockerfile in `support/site-docker` to make sure that the markdown files renders correctly.
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/
-----------------------------------------------------------
(Updated March 24, 2016, 2:22 p.m.)
Review request for mesos, Adam B and Joerg Schad.
Changes
-------
Removed another mention of the deprecated format.
Bugs: MESOS-2281
https://issues.apache.org/jira/browse/MESOS-2281
Repository: mesos
Description
-------
Deprecated the plain text credential format.
Diffs (updated)
-----
CHANGELOG 1fadaa1819c9b1a801752b1c0ddd572b82e6c170
docs/authentication.md 9f64f657d1a01f85f0132cb7264e2b85d0d3dc59
docs/configuration.md 70686adeca239b5962652a17661c8b0d44ca6708
docs/upgrades.md 85d02929b58b465f22d0e9991f6cf66f52b6d9a6
src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
src/master/flags.cpp 9b65dee02e3505f22aaa967899903f80fe0e7c57
src/slave/flags.cpp 71685cee58322e608139f7c344c2e954f7e14322
Diff: https://reviews.apache.org/r/44846/diff/
Testing (updated)
-------
make check
Created the documentation using the Dockerfile in `support/site-docker` to make sure that the markdown files renders correctly.
Thanks,
Jan Schlicht
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/
-----------------------------------------------------------
(Updated March 24, 2016, 1:45 p.m.)
Review request for mesos, Adam B and Joerg Schad.
Changes
-------
Addressed issues and rebased.
Bugs: MESOS-2281
https://issues.apache.org/jira/browse/MESOS-2281
Repository: mesos
Description
-------
Deprecated the plain text credential format.
Diffs (updated)
-----
CHANGELOG 1fadaa1819c9b1a801752b1c0ddd572b82e6c170
docs/authentication.md 9f64f657d1a01f85f0132cb7264e2b85d0d3dc59
docs/configuration.md 70686adeca239b5962652a17661c8b0d44ca6708
docs/upgrades.md 85d02929b58b465f22d0e9991f6cf66f52b6d9a6
src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
src/master/flags.cpp 9b65dee02e3505f22aaa967899903f80fe0e7c57
src/slave/flags.cpp 71685cee58322e608139f7c344c2e954f7e14322
Diff: https://reviews.apache.org/r/44846/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 15, 2016, 6:53 p.m., Greg Mann wrote:
> > FYI, this review: https://reviews.apache.org/r/44515/ adds command-line credentials to the agent with the `--http_credentials` flag. Depending on which one of these lands first, the other one should be updated to remain consistent.
Nevermind, I think it makes sense to simply remove documentation of the deprecated format from my patch, as Joerg suggested. No extra work needed on your part, Jan!
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review123720
-----------------------------------------------------------
On March 15, 2016, 2:01 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 2:01 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Deprecated the plain text credential format.
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b
> docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review123720
-----------------------------------------------------------
FYI, this review: https://reviews.apache.org/r/44515/ adds command-line credentials to the agent with the `--http_credentials` flag. Depending on which one of these lands first, the other one should be updated to remain consistent.
- Greg Mann
On March 15, 2016, 2:01 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 2:01 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Deprecated the plain text credential format.
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b
> docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review124528
-----------------------------------------------------------
I know we leave deprecated flags in and document them as deprecated, but I'm tempted to not even mention the deprecated format of a flag that will continue to exist. Is that crazy?
CHANGELOG (line 1)
<https://reviews.apache.org/r/44846/#comment187129>
Please add (WIP) at the end of this line
CHANGELOG (line 4)
<https://reviews.apache.org/r/44846/#comment187130>
s/providing//
docs/configuration.md (lines 507 - 508)
<https://reviews.apache.org/r/44846/#comment187131>
Let's not mention the deprecated format anymore. If they're still using it, they know how to format it. If not, they should just start with the new json format
docs/configuration.md (line 510)
<https://reviews.apache.org/r/44846/#comment187132>
s/JSON file Example/Example/
docs/configuration.md (lines 993 - 995)
<https://reviews.apache.org/r/44846/#comment187133>
Don't mention the deprecated format anymore.
src/master/flags.cpp (lines 224 - 227)
<https://reviews.apache.org/r/44846/#comment187134>
Remove the references to the deprecated format
src/master/flags.cpp (line 238)
<https://reviews.apache.org/r/44846/#comment187135>
No need for the final `\n`
src/slave/flags.cpp (lines 430 - 434)
<https://reviews.apache.org/r/44846/#comment187136>
"Path to a JSON-formatted file containing the credential to use to authenticate with the master."
- Adam B
On March 15, 2016, 7:01 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 7:01 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Deprecated the plain text credential format.
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b
> docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review124550
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44846]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 15, 2016, 2:01 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 2:01 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Deprecated the plain text credential format.
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b
> docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/
-----------------------------------------------------------
(Updated March 15, 2016, 3:01 p.m.)
Review request for mesos, Adam B and Joerg Schad.
Changes
-------
Addressed issues.
Bugs: MESOS-2281
https://issues.apache.org/jira/browse/MESOS-2281
Repository: mesos
Description (updated)
-------
Deprecated the plain text credential format.
Diffs (updated)
-----
CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b
docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338
src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
Diff: https://reviews.apache.org/r/44846/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review123639
-----------------------------------------------------------
Can you also add this upgrades.md?
- Joerg Schad
On March 15, 2016, 11:36 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 11:36 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Guangya Liu <gy...@gmail.com>.
> On 三月 15, 2016, 12:40 p.m., Guangya Liu wrote:
> > The configuration.md https://github.com/apache/mesos/blob/master/docs/configuration.md should also be updated.
>
> Joerg Schad wrote:
> see my 2nd comment above :-).
Sorry, I missed that, so you plan fix it in this patch or following patch? ;-)
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review123646
-----------------------------------------------------------
On 三月 15, 2016, 11:36 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated 三月 15, 2016, 11:36 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On March 15, 2016, 12:40 p.m., Guangya Liu wrote:
> > The configuration.md https://github.com/apache/mesos/blob/master/docs/configuration.md should also be updated.
see my 2nd comment above :-).
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review123646
-----------------------------------------------------------
On March 15, 2016, 11:36 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 11:36 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On March 15, 2016, 12:40 p.m., Guangya Liu wrote:
> > The configuration.md https://github.com/apache/mesos/blob/master/docs/configuration.md should also be updated.
>
> Joerg Schad wrote:
> see my 2nd comment above :-).
>
> Guangya Liu wrote:
> Sorry, I missed that, so you plan fix it in this patch or following patch? ;-)
NP, thanks for checking on such stuff! This will be fixed in this patch.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review123646
-----------------------------------------------------------
On March 15, 2016, 11:36 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 11:36 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 44846: Deprecated the plain text credential format.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review123646
-----------------------------------------------------------
The configuration.md https://github.com/apache/mesos/blob/master/docs/configuration.md should also be updated.
- Guangya Liu
On 三月 15, 2016, 11:36 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
>
> (Updated 三月 15, 2016, 11:36 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-2281
> https://issues.apache.org/jira/browse/MESOS-2281
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
> docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480
> src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9
>
> Diff: https://reviews.apache.org/r/44846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>