You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/02/20 23:06:16 UTC
Review Request: FLUME-1922. HDFS Sink should optionally insert the timestamp
at the sink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9532/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Add a new configuration param to optionally set the timestamp at the sink.
This addresses bug Flume-1922.
https://issues.apache.org/jira/browse/Flume-1922
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java fcc26f2
flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java 090b3a8
flume-ng-doc/sphinx/FlumeUserGuide.rst 8eb3734
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java e980d13
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java cdddd50
Diff: https://reviews.apache.org/r/9532/diff/
Testing
-------
Added a unit test. All current tests pass.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1922. HDFS Sink should optionally insert
the timestamp at the sink
Posted by Hari Shreedharan <hs...@cloudera.com>.
Sorry. Uploaded patch to wrong review. Closed this one as submitted.
On Tuesday, February 26, 2013, Hari Shreedharan wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9532/
> Review request for Flume.
> By Hari Shreedharan.
>
> *Updated Feb. 27, 2013, 3:54 a.m.*
> Changes
>
> Rebased. Not tested against Kerberos yet, will do that and update the jira later.
>
> Description
>
> Add a new configuration param to optionally set the timestamp at the sink.
>
> Testing
>
> Added a unit test. All current tests pass.
>
> *Bugs: * Flume-1922 <https://issues.apache.org/jira/browse/Flume-1922>
> Diffs (updated)
>
> - flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
> (0786857)
> - flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
> (76e3d1f)
> - flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java
> (ebe277c)
>
> View Diff <https://reviews.apache.org/r/9532/diff/>
>
Re: Review Request: FLUME-1922. HDFS Sink should optionally insert the
timestamp at the sink
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9532/
-----------------------------------------------------------
(Updated Feb. 27, 2013, 3:54 a.m.)
Review request for Flume.
Changes
-------
Rebased. Not tested against Kerberos yet, will do that and update the jira later.
Description
-------
Add a new configuration param to optionally set the timestamp at the sink.
This addresses bug Flume-1922.
https://issues.apache.org/jira/browse/Flume-1922
Diffs (updated)
-----
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 0786857
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 76e3d1f
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java ebe277c
Diff: https://reviews.apache.org/r/9532/diff/
Testing
-------
Added a unit test. All current tests pass.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1922. HDFS Sink should optionally insert the
timestamp at the sink
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9532/#review17121
-----------------------------------------------------------
Ship it!
+1 looks good, unit tests pass
- Mike Percy
On Feb. 26, 2013, 10:32 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9532/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2013, 10:32 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Add a new configuration param to optionally set the timestamp at the sink.
>
>
> This addresses bug Flume-1922.
> https://issues.apache.org/jira/browse/Flume-1922
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java fcc26f2
> flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java 090b3a8
> flume-ng-doc/sphinx/FlumeUserGuide.rst 8a4ecda
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java e980d13
> flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java cdddd50
>
> Diff: https://reviews.apache.org/r/9532/diff/
>
>
> Testing
> -------
>
> Added a unit test. All current tests pass.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1922. HDFS Sink should optionally insert the
timestamp at the sink
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9532/
-----------------------------------------------------------
(Updated Feb. 26, 2013, 10:32 p.m.)
Review request for Flume.
Description
-------
Add a new configuration param to optionally set the timestamp at the sink.
This addresses bug Flume-1922.
https://issues.apache.org/jira/browse/Flume-1922
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java fcc26f2
flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java 090b3a8
flume-ng-doc/sphinx/FlumeUserGuide.rst 8a4ecda
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java e980d13
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java cdddd50
Diff: https://reviews.apache.org/r/9532/diff/
Testing
-------
Added a unit test. All current tests pass.
Thanks,
Hari Shreedharan