svn commit: r1760133 - in /jmeter/trunk: src/core/org/apache/jmeter/report/processor/RequestsSummaryConsumer.java xdocs/changes.xml xdocs/usermanual/generating-dashboard.xml

[pm...@apache.org]

Author: pmouawad
Date: Sat Sep 10 08:10:15 2016
New Revision: 1760133

URL: http://svn.apache.org/viewvc?rev=1760133&view=rev
Log:
Bug 60103 - Report / Dashboard : Requests summary includes Transaction Controller leading to wrong percentage
Bugzilla Id: 60103

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/report/processor/RequestsSummaryConsumer.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/generating-dashboard.xml

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/RequestsSummaryConsumer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/RequestsSummaryConsumer.java?rev=1760133&r1=1760132&r2=1760133&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/RequestsSummaryConsumer.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/RequestsSummaryConsumer.java Sat Sep 10 08:10:15 2016
@@ -54,9 +54,11 @@ public class RequestsSummaryConsumer ext
      */
     @Override
     public void consume(Sample sample, int channel) {
-        count++;
-        if (!sample.getSuccess()) {
-            errorCount++;
+        if(!sample.isController()) {
+            count++;
+            if (!sample.getSuccess()) {
+                errorCount++;
+            }
         }
         super.produce(sample, channel);
     }

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1760133&r1=1760132&r2=1760133&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Sep 10 08:10:15 2016
@@ -209,6 +209,7 @@ Summary
     <li><bug>60049</bug>When using Timers with high delays or Constant Throughput Timer with low throughput, Scheduler may take a lot of time to exit, same for Shutdown test </li>
     <li><bug>60089</bug>Report / Dashboard : Bytes throughput Over Time has reversed Sent and Received bytes. Contributed by Ubik Load Pack (support at ubikloadpack.com)</li>
     <li><bug>60090</bug>Report / Dashboard : Empty Transaction Controller should not count in metrics</li>
+    <li><bug>60103</bug>Report / Dashboard : Requests summary includes Transaction Controller leading to wrong percentage</li>
 </ul>
 
  <!--  =================== Thanks =================== -->

Modified: jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/generating-dashboard.xml?rev=1760133&r1=1760132&r2=1760133&view=diff
==============================================================================
--- jmeter/trunk/xdocs/usermanual/generating-dashboard.xml (original)
+++ jmeter/trunk/xdocs/usermanual/generating-dashboard.xml Sat Sep 10 08:10:15 2016
@@ -28,7 +28,7 @@
                 This report provides the following metrics:
                 <ul>
                     <li><a href="https://en.wikipedia.org/wiki/Apdex" title="Application Performance Index" target="_blank">APDEX</a> (Application Performance Index) table that computes for every transaction the APDEX based on configurable values for tolerated and satisfied thresholds</li>
-                    <li>A request summary graph showing the Success and failed transaction percentage: <figure width="1658" height="650" image="dashboard/report_apdex_and_summary.png" ></figure></li>
+                    <li>A request summary graph showing the Success and failed requests (Transaction Controller Sample Results are not taken into account) percentage: <figure width="1658" height="650" image="dashboard/report_apdex_and_summary.png" ></figure></li>
                     <li>A Statistics table providing in one table a summary of all metrics per transaction including 3 configurable percentiles : <figure width="1376" height="433" image="dashboard/report_statistics.png" ></figure></li>
                     <li>An error table providing a summary of all errors and their proportion in the total requests : <figure width="1344" height="455" image="dashboard/report_errors.png" ></figure></li>
                     <li>Zoomable chart where you can check/uncheck every transaction to show/hide it for: