You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "fvaleri (via GitHub)" <gi...@apache.org> on 2023/04/03 06:36:47 UTC

[GitHub] [kafka] fvaleri opened a new pull request, #13492: KAFKA-14752: Kafka examples improvements

fvaleri opened a new pull request, #13492:
URL: https://github.com/apache/kafka/pull/13492

   This is an attempt to improve the Kafka examples module.
   
   There is some heavy refactoring and minor fixes, but the original logic and script interface is kept. Below you can find the list of major changes and fixes:
   
   - Make scripts shellcheck compliant
   - Convert the readme to markdown as in other modules
   - Remove unnecessary dependency on server-common module
   - Move all classes from kafka.examples to org.apache.kafka.examples
   - Add missing and improve existing javadoc
   - Fix not enough replicas when default minISR>1
   - Add producer and consumer client id config
   - Improve log formatting and avoid printing all messages
   - Fix producer consumer driver hanging on timeout
   - Remove constructor logic and use try-with-resources
   - Improve EOS example and processor
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] fvaleri commented on pull request #13492: KAFKA-14752: Kafka examples improvements

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on PR #13492:
URL: https://github.com/apache/kafka/pull/13492#issuecomment-1498749238

   @showuon sure, sounds like a plan. Will move this to draft and open dedicated PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] fvaleri closed pull request #13492: KAFKA-14752: Kafka examples improvements

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri closed pull request #13492: KAFKA-14752: Kafka examples improvements
URL: https://github.com/apache/kafka/pull/13492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] fvaleri commented on pull request #13492: KAFKA-14752: Kafka examples improvements

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on PR #13492:
URL: https://github.com/apache/kafka/pull/13492#issuecomment-1531544193

   This PR was broken into multiple reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] fvaleri commented on pull request #13492: KAFKA-14752: Kafka examples improvements

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on PR #13492:
URL: https://github.com/apache/kafka/pull/13492#issuecomment-1494641695

   Hi @divijvaidya, I restored the original layout to make review easier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] divijvaidya commented on pull request #13492: KAFKA-14752: Kafka examples improvements

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13492:
URL: https://github.com/apache/kafka/pull/13492#issuecomment-1494096264

   May I suggest having different PRs for package change and the actual code changes? It would help view the diff of changes clearly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a diff in pull request #13492: KAFKA-14752: Kafka examples improvements

Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #13492:
URL: https://github.com/apache/kafka/pull/13492#discussion_r1158297917


##########
checkstyle/import-control-core.xml:
##########
@@ -71,7 +71,6 @@
 
   <subpackage name="examples">
     <allow pkg="org.apache.kafka.clients" />
-    <allow pkg="org.apache.kafka.server.util" />

Review Comment:
   Nice catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org