You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Hugo Trippaers <HT...@schubergphilis.com> on 2013/01/22 11:04:30 UTC

schema-40to41.sql; Commit e4dbc2033fa6071039df65f414e004611b361108

Hey Min,

Can you have a look at this file? The schema-40to41.sql that you commited did not work for me

* SQL comments are two dashes, not three
* I can't find table vm_template_iso in  Apache CloudStack
* You added 'use cloud' somewhere in the middle, please stick to the standard of prefixing tables with `cloud`.

I fixed most of the issues I could find and currently it is possible to apply this sql file. Could you carefully review the changes?

My commit is https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=3bac7b8c07b21eaa3a7b244f4d74efa7b4b5b41f

Cheers,

Hugo

Re: schema-40to41.sql; Commit e4dbc2033fa6071039df65f414e004611b361108

Posted by Min Chen <mi...@citrix.com>.

Committed the fix in
https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit
;h=2130a418e01058f67ceeaaa298119cf59f9e0835

Thanks
-min

On 1/22/13 9:26 AM, "Min Chen" <mi...@citrix.com> wrote:

>Thanks Hugo. I reviewed your change, most are ok, except your fix on
>"vm_template iso". There is no table vm_template_iso, my previous SQL
>statement is to use alias as "cloud.vm_template iso". I will fix that.
>Also will do the similar formatting and prefixing tables with 'cloud' in
>fresh install sql as well.
>
>-min
>
>On 1/22/13 2:04 AM, "Hugo Trippaers" <HT...@schubergphilis.com>
>wrote:
>
>>Hey Min,
>>
>>Can you have a look at this file? The schema-40to41.sql that you commited
>>did not work for me
>>
>>* SQL comments are two dashes, not three
>>* I can't find table vm_template_iso in  Apache CloudStack
>>* You added 'use cloud' somewhere in the middle, please stick to the
>>standard of prefixing tables with `cloud`.
>>
>>I fixed most of the issues I could find and currently it is possible to
>>apply this sql file. Could you carefully review the changes?
>>
>>My commit is 
>>https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=comm
>>i
>>t;h=3bac7b8c07b21eaa3a7b244f4d74efa7b4b5b41f
>>
>>Cheers,
>>
>>Hugo
>>
>>
>

Re: schema-40to41.sql; Commit e4dbc2033fa6071039df65f414e004611b361108

Posted by Min Chen <mi...@citrix.com>.

Thanks Hugo. I reviewed your change, most are ok, except your fix on
"vm_template iso". There is no table vm_template_iso, my previous SQL
statement is to use alias as "cloud.vm_template iso". I will fix that.
Also will do the similar formatting and prefixing tables with 'cloud' in
fresh install sql as well.

-min

On 1/22/13 2:04 AM, "Hugo Trippaers" <HT...@schubergphilis.com> wrote:

>Hey Min,
>
>Can you have a look at this file? The schema-40to41.sql that you commited
>did not work for me
>
>* SQL comments are two dashes, not three
>* I can't find table vm_template_iso in  Apache CloudStack
>* You added 'use cloud' somewhere in the middle, please stick to the
>standard of prefixing tables with `cloud`.
>
>I fixed most of the issues I could find and currently it is possible to
>apply this sql file. Could you carefully review the changes?
>
>My commit is 
>https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commi
>t;h=3bac7b8c07b21eaa3a7b244f4d74efa7b4b5b41f
>
>Cheers,
>
>Hugo
>
>