You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/04/27 16:47:21 UTC
[GitHub] [nifi] juldrixx commented on a diff in pull request #5868: NIFI-9798 Add proxy configuration to pubsub processor
juldrixx commented on code in PR #5868:
URL: https://github.com/apache/nifi/pull/5868#discussion_r860020149
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/AbstractGCPubSubProcessor.java:
##########
@@ -58,6 +73,19 @@ public abstract class AbstractGCPubSubProcessor extends AbstractGCPProcessor imp
private static final Set<Relationship> relationships = Collections.unmodifiableSet(new HashSet<>(Arrays.asList(REL_SUCCESS, REL_FAILURE)));
+ @Override
+ public List<PropertyDescriptor> getSupportedPropertyDescriptors() {
+ return Collections.unmodifiableList(Arrays.asList(
+ PROJECT_ID,
+ GCP_CREDENTIALS_PROVIDER_SERVICE,
+ PROXY_HOST,
+ PROXY_PORT,
+ HTTP_PROXY_USERNAME,
+ HTTP_PROXY_PASSWORD,
Review Comment:
I did it like It was done [here](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java#L123). So I should remove the individual properties and just let the `ProxyConfiguration...` thing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org