You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/02 11:32:44 UTC

[GitHub] [airflow] flvndh opened a new issue #14557: AzureDataFactoryHook fails to instantiate its connection

flvndh opened a new issue #14557:
URL: https://github.com/apache/airflow/issues/14557


   `AzureDataFactoryHook` inherits from `AzureBaseHook` as it has all the logic to instantiate the SDK client.
   https://github.com/apache/airflow/blob/1f5b764f6573f80276cf87d061b91d45ad92e51a/airflow/providers/microsoft/azure/hooks/azure_data_factory.py#L72
   https://github.com/apache/airflow/blob/1f5b764f6573f80276cf87d061b91d45ad92e51a/airflow/providers/microsoft/azure/hooks/base_azure.py#L67-L72
   
   The issue is that `DataFactoryManagementClient` has a slightly different signature than most Azure SDK clients (notice the missing "s" in "credentials"):
   ```python
   DataFactoryManagementClient(credential, subscription_id, base_url=None, **kwargs)
   ```
   
   One possible solution would be to adapt the signature of the client to match the one required by `AzureBaseHook` here:
   https://github.com/apache/airflow/blob/1f5b764f6573f80276cf87d061b91d45ad92e51a/airflow/providers/microsoft/azure/hooks/azure_data_factory.py#L79-L80


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil closed issue #14557: AzureDataFactoryHook fails to instantiate its connection

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #14557:
URL: https://github.com/apache/airflow/issues/14557


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org