You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "982945902 (via GitHub)" <gi...@apache.org> on 2023/09/06 06:50:07 UTC
[PR] fix h2 protocol abnormal case when SETTINGS_HEADER_TABLE_SIZE set to zero (brpc)
982945902 opened a new pull request, #2373:
URL: https://github.com/apache/brpc/pull/2373
### What problem does this PR solve?
when use h2:grpc protocol pass nginx, if nginx not support dynamic HPACK, it will set SETTINGS_HEADER_TABLE_SIZE value to 0，now brpc not address this case.
https://trac.nginx.org/nginx/ticket/1538
rfc reference: https://datatracker.ietf.org/doc/html/rfc9113 4.3.1
Issue Number:
https://github.com/apache/brpc/issues/2286
https://github.com/apache/brpc/issues/2176
Problem Summary:
ignore a h2 protocol param set case
### What is changed and the side effects?
Changed:
add a if check when encode h2 header
Side effects:
- Performance effects(性能影响):
It hardly makes a difference
- Breaking backward compatibility(向后兼容性):
completely compatible
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix h2 protocol abnormal case when SETTINGS_HEADER_TABLE_SIZE set to zero (brpc)
Posted by "982945902 (via GitHub)" <gi...@apache.org>.
982945902 commented on PR #2373:
URL: https://github.com/apache/brpc/pull/2373#issuecomment-1708523061
Put it another way because of dynamic table size limitation, HTTP/2.0 uses dynamic tables to store the most recently used request header fields for compression and reuse. If the dynamic table reaches a size limit, the new request Header Field is sent using the Literal Header Field without Indexing encoding to avoid overflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix h2 protocol abnormal case when SETTINGS_HEADER_TABLE_SIZE set to zero (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm merged PR #2373:
URL: https://github.com/apache/brpc/pull/2373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix h2 protocol abnormal case when SETTINGS_HEADER_TABLE_SIZE set to zero (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2373:
URL: https://github.com/apache/brpc/pull/2373#issuecomment-1709792352
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix h2 protocol abnormal case when SETTINGS_HEADER_TABLE_SIZE set to zero (brpc)
Posted by "982945902 (via GitHub)" <gi...@apache.org>.
982945902 commented on PR #2373:
URL: https://github.com/apache/brpc/pull/2373#issuecomment-1708539180
https://datatracker.ietf.org/doc/html/rfc7541#section-4.2 about Maximum Table Size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org