You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by David Radley <da...@uk.ibm.com> on 2017/06/19 22:48:30 UTC
Review Request 60213: addressing Coverity Scan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60213/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
Repository: atlas
Description
-------
addressing Coverity Scan for Jira ATLAS-1887
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6c33f4024dcf81c73bce74b76824910eaec13085
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java eb2fc48bc8c8745c04cfa21c52e583b3bd352fd9
intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 7a4e9fd500456a326d4d52732639d69ff9be510f
Diff: https://reviews.apache.org/r/60213/diff/1/
Testing
-------
Run junits
Created a relationshipDef and then did a get on it.
Thanks,
David Radley
Re: Review Request 60213: addressing Coverity Scan
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60213/#review178349
-----------------------------------------------------------
Fix it, then Ship it!
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 82 (patched)
<https://reviews.apache.org/r/60213/#comment252256>
increment the error code number -> ATLAS-400-00-035
- Sarath Subramanian
On June 19, 2017, 3:48 p.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60213/
> -----------------------------------------------------------
>
> (Updated June 19, 2017, 3:48 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> addressing Coverity Scan for Jira ATLAS-1887
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6c33f4024dcf81c73bce74b76824910eaec13085
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java eb2fc48bc8c8745c04cfa21c52e583b3bd352fd9
> intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 7a4e9fd500456a326d4d52732639d69ff9be510f
>
>
> Diff: https://reviews.apache.org/r/60213/diff/1/
>
>
> Testing
> -------
>
> Run junits
> Created a relationshipDef and then did a get on it.
>
>
> Thanks,
>
> David Radley
>
>
Re: Review Request 60213: addressing Coverity Scan
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60213/#review178403
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
Lines 137 (patched)
<https://reviews.apache.org/r/60213/#comment252335>
Shouldn't both ends be non-null? The validation here allows both ends be null. What would be the usecase for this?
- Madhan Neethiraj
On June 20, 2017, 3:19 p.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60213/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 3:19 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> addressing Coverity Scan for Jira ATLAS-1887
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java e8971a80e38b1ee2337cebc696ccb23bf5cd3323
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 296c06c260e471f6e2effde14ee905eb305cbe74
> intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 7a4e9fd500456a326d4d52732639d69ff9be510f
>
>
> Diff: https://reviews.apache.org/r/60213/diff/3/
>
>
> Testing
> -------
>
> Run junits
> Created a relationshipDef and then did a get on it.
>
>
> Thanks,
>
> David Radley
>
>
Re: Review Request 60213: addressing Coverity Scan
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60213/#review178540
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On June 21, 2017, 9:47 a.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60213/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 9:47 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> addressing Coverity Scan for Jira ATLAS-1887
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 296c06c260e471f6e2effde14ee905eb305cbe74
>
>
> Diff: https://reviews.apache.org/r/60213/diff/4/
>
>
> Testing
> -------
>
> Run junits
> Created a relationshipDef and then did a get on it.
>
>
> Thanks,
>
> David Radley
>
>
Re: Review Request 60213: addressing Coverity Scan
Posted by David Radley <da...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60213/
-----------------------------------------------------------
(Updated June 21, 2017, 9:47 a.m.)
Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
Changes
-------
With the latest changes from Sarath - the endpoints cannot be null when going into the validate method. I have therefore removed all the null end checks from the validate method.
Repository: atlas
Description
-------
addressing Coverity Scan for Jira ATLAS-1887
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 296c06c260e471f6e2effde14ee905eb305cbe74
Diff: https://reviews.apache.org/r/60213/diff/4/
Changes: https://reviews.apache.org/r/60213/diff/3-4/
Testing
-------
Run junits
Created a relationshipDef and then did a get on it.
Thanks,
David Radley
Re: Review Request 60213: addressing Coverity Scan
Posted by David Radley <da...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60213/
-----------------------------------------------------------
(Updated June 20, 2017, 3:19 p.m.)
Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
Changes
-------
amending the message number again as it clashes with another commit.
Repository: atlas
Description
-------
addressing Coverity Scan for Jira ATLAS-1887
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java e8971a80e38b1ee2337cebc696ccb23bf5cd3323
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 296c06c260e471f6e2effde14ee905eb305cbe74
intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 7a4e9fd500456a326d4d52732639d69ff9be510f
Diff: https://reviews.apache.org/r/60213/diff/3/
Changes: https://reviews.apache.org/r/60213/diff/2-3/
Testing
-------
Run junits
Created a relationshipDef and then did a get on it.
Thanks,
David Radley
Re: Review Request 60213: addressing Coverity Scan
Posted by David Radley <da...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60213/
-----------------------------------------------------------
(Updated June 20, 2017, 7:46 a.m.)
Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
Changes
-------
Made the message number unique
Repository: atlas
Description
-------
addressing Coverity Scan for Jira ATLAS-1887
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6c33f4024dcf81c73bce74b76824910eaec13085
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java eb2fc48bc8c8745c04cfa21c52e583b3bd352fd9
intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 7a4e9fd500456a326d4d52732639d69ff9be510f
Diff: https://reviews.apache.org/r/60213/diff/2/
Changes: https://reviews.apache.org/r/60213/diff/1-2/
Testing
-------
Run junits
Created a relationshipDef and then did a get on it.
Thanks,
David Radley