You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "maytasm (via GitHub)" <gi...@apache.org> on 2023/05/02 02:39:45 UTC

[GitHub] [spark] maytasm commented on pull request #36226: [SPARK-38924][UI] Update datatables to 1.10.25

maytasm commented on PR #36226:
URL: https://github.com/apache/spark/pull/36226#issuecomment-1530789474

   @gengliangwang @srowen looks like this change broke the sorting arrow on the table. The sort_asc.png and sort_ desc.png is not displayed in the table. I believe this is because the jquery.dataTables.1.10.25.min.css uses `!important` for the sort_asc.png and sort_ desc.png 
   i.e. `.sorting_asc{background-image:url("../images/sort_asc.png") !important`
   Seems like this is not a problem in master branch as we upgraded DataTables from 1.10.25 to 1.13.2
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org