You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ankita Sinha <an...@freestoneinfotech.com> on 2016/06/22 08:56:07 UTC

Review Request 49073: Ranger KMS repo creation is failing after Ranger KMS is installed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49073/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1046
    https://issues.apache.org/jira/browse/RANGER-1046


Repository: ranger


Description
-------

**Problem Statement**
Ranger KMS repo creation is failing after Ranger KMS is installed
Repo is not found at ranger side

**Solution**
1. To Allow create Repo of KMS from Ranger after Authentication
2. Allow download policy to user having either keyadmin role or is in either "policy.download.auth.user" or "policy.grantrevoke.auth.users" list


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 794de71 
  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 5d0551a 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java aa5188c 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java 4439be1 

Diff: https://reviews.apache.org/r/49073/diff/


Testing
-------

Tested default Repo creation for Ranger KMS for refresh install
Tested default Repo creation for one other plugin
Tested Download Policy for Ranger KMS
Tested Download Policy for one other Plugin
Tested KMS Key operartions from Ranger UI Encryption Tab


Thanks,

Ankita Sinha


Re: Review Request 49073: Ranger KMS repo creation is failing after Ranger KMS is installed

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49073/#review139070
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java (line 1465)
<https://reviews.apache.org/r/49073/#comment204226>

    Any specific reason why this method duplicates isValidateHttpsAuthentication? Can the existing method be not used?


- Velmurugan Periasamy


On June 22, 2016, 8:56 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49073/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 8:56 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1046
>     https://issues.apache.org/jira/browse/RANGER-1046
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement**
> Ranger KMS repo creation is failing after Ranger KMS is installed
> Repo is not found at ranger side
> 
> **Solution**
> 1. To Allow create Repo of KMS from Ranger after Authentication
> 2. Allow download policy to user having either keyadmin role or is in either "policy.download.auth.user" or "policy.grantrevoke.auth.users" list
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 794de71 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 5d0551a 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java aa5188c 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java 4439be1 
> 
> Diff: https://reviews.apache.org/r/49073/diff/
> 
> 
> Testing
> -------
> 
> Tested default Repo creation for Ranger KMS for refresh install
> Tested default Repo creation for one other plugin
> Tested Download Policy for Ranger KMS
> Tested Download Policy for one other Plugin
> Tested KMS Key operartions from Ranger UI Encryption Tab
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Re: Review Request 49073: Ranger KMS repo creation is failing after Ranger KMS is installed

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49073/#review139338
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On June 24, 2016, 3:33 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49073/
> -----------------------------------------------------------
> 
> (Updated June 24, 2016, 3:33 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1046
>     https://issues.apache.org/jira/browse/RANGER-1046
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement**
> Ranger KMS repo creation is failing after Ranger KMS is installed
> Repo is not found at ranger side
> 
> **Solution**
> 1. To Allow create Repo of KMS from Ranger after Authentication
> 2. Allow download policy to user having either keyadmin role or is in either "policy.download.auth.user" or "policy.grantrevoke.auth.users" list
> 
> 
> Diffs
> -----
> 
>   kms/scripts/ranger-kms b51e051 
>   kms/scripts/ranger-kms-initd c96988f 
>   kms/scripts/setup.sh b44f6ba 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 93603ff 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 5d0551a 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java aa5188c 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java 4439be1 
> 
> Diff: https://reviews.apache.org/r/49073/diff/
> 
> 
> Testing
> -------
> 
> Tested default Repo creation for Ranger KMS for refresh install
> Tested default Repo creation for one other plugin
> Tested Download Policy for Ranger KMS
> Tested Download Policy for one other Plugin
> Tested KMS Key operartions from Ranger UI Encryption Tab
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Re: Review Request 49073: Ranger KMS repo creation is failing after Ranger KMS is installed

Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49073/
-----------------------------------------------------------

(Updated June 24, 2016, 3:33 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1046
    https://issues.apache.org/jira/browse/RANGER-1046


Repository: ranger


Description
-------

**Problem Statement**
Ranger KMS repo creation is failing after Ranger KMS is installed
Repo is not found at ranger side

**Solution**
1. To Allow create Repo of KMS from Ranger after Authentication
2. Allow download policy to user having either keyadmin role or is in either "policy.download.auth.user" or "policy.grantrevoke.auth.users" list


Diffs (updated)
-----

  kms/scripts/ranger-kms b51e051 
  kms/scripts/ranger-kms-initd c96988f 
  kms/scripts/setup.sh b44f6ba 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 93603ff 
  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 5d0551a 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java aa5188c 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java 4439be1 

Diff: https://reviews.apache.org/r/49073/diff/


Testing
-------

Tested default Repo creation for Ranger KMS for refresh install
Tested default Repo creation for one other plugin
Tested Download Policy for Ranger KMS
Tested Download Policy for one other Plugin
Tested KMS Key operartions from Ranger UI Encryption Tab


Thanks,

Ankita Sinha


Re: Review Request 49073: Ranger KMS repo creation is failing after Ranger KMS is installed

Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49073/
-----------------------------------------------------------

(Updated June 23, 2016, 4:26 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1046
    https://issues.apache.org/jira/browse/RANGER-1046


Repository: ranger


Description
-------

**Problem Statement**
Ranger KMS repo creation is failing after Ranger KMS is installed
Repo is not found at ranger side

**Solution**
1. To Allow create Repo of KMS from Ranger after Authentication
2. Allow download policy to user having either keyadmin role or is in either "policy.download.auth.user" or "policy.grantrevoke.auth.users" list


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 93603ff 
  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 5d0551a 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java aa5188c 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java 4439be1 

Diff: https://reviews.apache.org/r/49073/diff/


Testing
-------

Tested default Repo creation for Ranger KMS for refresh install
Tested default Repo creation for one other plugin
Tested Download Policy for Ranger KMS
Tested Download Policy for one other Plugin
Tested KMS Key operartions from Ranger UI Encryption Tab


Thanks,

Ankita Sinha