You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/07/06 02:46:18 UTC
[jira] [Commented] (HIVE-2260) ExecDriver::addInputPaths should
pass the table properties to the record writer
[ https://issues.apache.org/jira/browse/HIVE-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060222#comment-13060222 ]
jiraposter@reviews.apache.org commented on HIVE-2260:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1014/
-----------------------------------------------------------
Review request for hive.
Summary
-------
Currently when ExecDriver encounters a non-existent partition, it creates an empty file so that the query will be valid (and return 0 results). However, when it does this and calls getHiveRecordWriter(), it creates a new instance of Properties, rather than providing the Properties associated with the table.
This causes RecordWriters that pull information from the table through the Properties to fail (such as Haivvreo). The RecordWriter should be provided the table's Properties, as it is in all other cases where it's called.
This addresses bug HIVE-2260.
https://issues.apache.org/jira/browse/HIVE-2260
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 4fba845
Diff: https://reviews.apache.org/r/1014/diff
Testing
-------
Thanks,
Jakob
> ExecDriver::addInputPaths should pass the table properties to the record writer
> -------------------------------------------------------------------------------
>
> Key: HIVE-2260
> URL: https://issues.apache.org/jira/browse/HIVE-2260
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2260.patch
>
>
> Currently when ExecDriver encounters a non-existent partition, it creates an empty file so that the query will be valid (and return 0 results). However, when it does this and calls {{getHiveRecordWriter()}}, it creates a new instance of Properties, rather than providing the Properties associated with the table.
> This causes RecordWriters that pull information from the table through the Properties to fail (such as [Haivvreo|http://bit.ly/iwEQzJ]). The RecordWriter should be provided the table's Properties, as it is in all other cases where it's called.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira