You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "JHoelli (via GitHub)" <gi...@apache.org> on 2025/10/17 11:38:37 UTC
[PR] Moved Add Assets for Charts from PopUp during Save to Button in Edit Mode
JHoelli opened a new pull request, #3853:
URL: https://github.com/apache/streampipes/pull/3853
### Purpose
Related to #3841 , moved the Add Asset Popup from Save to an extra Button during edit mode and fixed the tests.
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved Add Assets for Charts from PopUp during Save to Button in Edit Mode
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe merged PR #3853:
URL: https://github.com/apache/streampipes/pull/3853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved Add Assets for Charts from PopUp during Save to Button in Edit Mode
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on code in PR #3853:
URL: https://github.com/apache/streampipes/pull/3853#discussion_r2440240785
##########
ui/cypress/support/utils/dataExplorer/DataExplorerUtils.ts:
##########
@@ -114,7 +114,54 @@ export class DataExplorerUtils {
cy.wait(1000);
}
+ public static addAssetsToDashboard(assetNameList) {
+ cy.dataCy('sp-show-dashboard-asset-checkbox')
+ .find('input[type="checkbox"]')
+ .then($checkbox => {
+ if (!$checkbox.prop('checked')) {
+ cy.wrap($checkbox).click();
+ }
+ });
+ cy.get('mat-tree.asset-tree', { timeout: 10000 }).should('exist');
+ assetNameList.forEach(assetName => {
+ console.log(assetName);
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved Add Assets for Charts from PopUp during Save to Button in Edit Mode
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on code in PR #3853:
URL: https://github.com/apache/streampipes/pull/3853#discussion_r2440239972
##########
ui/cypress/support/utils/dataExplorer/DataExplorerUtils.ts:
##########
@@ -216,6 +264,24 @@ export class DataExplorerUtils {
return cy.dataCy('empty-dashboard');
}
+ public static addChartsToAsset(assetNameList = []) {
+ //Click on Button
Review Comment:
Can you remove the comments and extract the calls to a uitls method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org