You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by smarthi <gi...@git.apache.org> on 2016/07/23 22:35:57 UTC

[GitHub] incubator-pirk pull request #22: PIRK-24: JMH and Pom, exclude benchmark cla...

GitHub user smarthi opened a pull request:

    https://github.com/apache/incubator-pirk/pull/22

    PIRK-24: JMH and Pom, exclude benchmark classes and jmh jars from being packaged into uber jar

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smarthi/incubator-pirk PIRK-24

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pirk/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22
    
----
commit a318ad21c56dbfc4bfb51fe67bfcd41500d4b8d7
Author: smarthi <sm...@apache.org>
Date:   2016-07-23T21:58:30Z

    PIRK-24: JMH and Pom, exclude benchmark classes from being packaged into the jar

commit 3c04c34e50a346d230703c5cb30599fa3f47894e
Author: smarthi <sm...@apache.org>
Date:   2016-07-23T22:33:37Z

    PIRK-24: JMH and Pom, exclude benchmark classes and jmh jars from being packaged into the uber jar

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #22: [PIRK-24]: JMH and Pom, exclude benchmark c...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-pirk/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #22: PIRK-24: JMH and Pom, exclude benchmark classes an...

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/22
  
    1. Changed the <scope> of JMH dependencies to "provided", that excludes the jmh jars from being packaged into the uber jar
    2. Added maven-jar-plugin and excluded "org/openjdg/jmh/**" to exclude jmh generated classes and also excluded "org/apache/pirk/benchmark/**" to exclude the PIRK benchmark classes that use jmh.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---