[jira] [Commented] (ZOOKEEPER-1328) Misplaced assertion for the test case 'FLELostMessageTest' and not identifying misfunctions

["Rakesh R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446604#comment-13446604 ] 

Rakesh R commented on ZOOKEEPER-1328:
-------------------------------------

Thanks a lot Mahadev. QA Report has been generated, could you please have a look at the report.
                
> Misplaced assertion for the test case 'FLELostMessageTest' and not identifying misfunctions
> -------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1328
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1328
>             Project: ZooKeeper
>          Issue Type: Test
>          Components: leaderElection
>    Affects Versions: 3.4.0
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1328.1.patch, ZOOKEEPER-1328.2.patch, ZOOKEEPER-1328.patch
>
>
> Assertion for testLostMessage is kept inside the thread.run() method. Due to this the assertion failure will not be reflected in the main testcase. 
> I have observed the test case is still passing in case of the assert failure or misfunction. Instead, the assertion can be moved to the test case - testLostMessage.
> {noformat}
> class LEThread extends Thread {
>           public void run(){
>                 peer.setCurrentVote(v);
>                 LOG.info("Finished election: " + i + ", " + v.getId());
>                 Assert.assertTrue("State is not leading.", peer.getPeerState() == ServerState.LEADING);
>              } 
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira