You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/14 16:11:25 UTC

[jira] [Commented] (FLINK-3760) Fix StateDescriptor.readObject

    [ https://issues.apache.org/jira/browse/FLINK-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241213#comment-15241213 ] 

ASF GitHub Bot commented on FLINK-3760:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/1888

    [FLINK-3760] Fix StateDescriptor.readObject

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink state-descriptor-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1888
    
----
commit db0a97629a8f3f760bb031bf1e0734c7ec5e81b2
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-04-14T14:10:06Z

    [FLINK-3760] Fix StateDescriptor.readObject

----


> Fix StateDescriptor.readObject 
> -------------------------------
>
>                 Key: FLINK-3760
>                 URL: https://issues.apache.org/jira/browse/FLINK-3760
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 1.0.0, 1.0.1
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Critical
>             Fix For: 1.0.2
>
>
> The readObject method of StateDescriptor uses uses {{ObjectInputStream.read()}}. For very large serialized default values this will not necessarily read all data in one go. We need a loop that reads it in several steps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)