You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/30 08:23:00 UTC

[GitHub] [superset] geido commented on a change in pull request #16911: test: Cypress 7.0.0 migration

geido commented on a change in pull request #16911:
URL: https://github.com/apache/superset/pull/16911#discussion_r719173535



##########
File path: superset-frontend/cypress-base/package.json
##########
@@ -5,19 +5,19 @@
   "scripts": {
     "cypress": "cypress",
     "cypress-run-chrome": "cypress run --browser chrome --headless",
-    "cypress-debug": "cypress open --config watchForFileChanges=true"
+    "cypress-open-debug": "cypress open --config watchForFileChanges=true"

Review comment:
       Just a nit. I think many people might be used to this command and changing it might cause a surprise. Not too sure I see the benefit compared to just leaving it as it was.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org