You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "kk-src (via GitHub)" <gi...@apache.org> on 2025/11/21 03:12:29 UTC
[PR] PG18 port for AGE [age]
kk-src opened a new pull request, #2251:
URL: https://github.com/apache/age/pull/2251
## Summary:
This PR ports Apache AGE to work with PG18
[PG18 port][Set1] Fix header dependencies and use TupleDescAttr macro
[PG18 port][Set2] Adapt to expandRTE signature change and pg_noreturn
[PG18 port][Set3] Fix double ExecOpenIndices call for PG18 compatibility
[PG18 port][Set4] Update regression test expected output for ordering
## Testing:
```
ok 1 - scan 477 ms
ok 2 - graphid 22 ms
ok 3 - agtype 290 ms
ok 4 - agtype_hash_cmp 16 ms
ok 5 - catalog 263 ms
ok 6 - cypher 94 ms
ok 7 - expr 1300 ms
ok 8 - cypher_create 253 ms
ok 9 - cypher_match 1173 ms
ok 10 - cypher_unwind 94 ms
ok 11 - cypher_set 263 ms
ok 12 - cypher_remove 148 ms
ok 13 - cypher_delete 372 ms
ok 14 - cypher_with 138 ms
ok 15 - cypher_vle 2146 ms
ok 16 - cypher_union 47 ms
ok 17 - cypher_call 63 ms
ok 18 - cypher_merge 611 ms
ok 19 - cypher_subquery 139 ms
ok 20 - age_global_graph 280 ms
ok 21 - age_load 3263 ms
ok 22 - index 169 ms
ok 23 - analyze 41 ms
ok 24 - graph_generation 142 ms
ok 25 - name_validation 300 ms
ok 26 - jsonb_operators 206 ms
ok 27 - list_comprehension 117 ms
ok 28 - map_projection 63 ms
ok 29 - drop 662 ms
1..29
# All 29 tests passed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PG18 port for AGE [age]
Posted by "kk-src (via GitHub)" <gi...@apache.org>.
kk-src commented on PR #2251:
URL: https://github.com/apache/age/pull/2251#issuecomment-3573136754
The commits with signing has been updated as well. Please let me know next steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PG18 port for AGE [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on code in PR #2251:
URL: https://github.com/apache/age/pull/2251#discussion_r2550988983
##########
src/backend/executor/cypher_set.c:
##########
@@ -141,7 +152,8 @@ static HeapTuple update_entity_tuple(ResultRelInfo *resultRelInfo,
errmsg("tuple to be updated was already modified")));
}
- ExecCloseIndices(resultRelInfo);
+ if (close_indices)
Review Comment:
Our coding standard requires that all if/else blocks must have opening and closing braces.
##########
src/backend/executor/cypher_set.c:
##########
@@ -160,7 +172,8 @@ static HeapTuple update_entity_tuple(ResultRelInfo *resultRelInfo,
(update_indexes == TU_Summarizing));
}
- ExecCloseIndices(resultRelInfo);
+ if (close_indices)
Review Comment:
Our coding standard requires that all if/else blocks must have opening and closing braces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PG18 port for AGE [age]
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed merged PR #2251:
URL: https://github.com/apache/age/pull/2251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PG18 port for AGE [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #2251:
URL: https://github.com/apache/age/pull/2251#issuecomment-3572703942
@kk-src @MuhammadTahaNaveed It also ran the issue the other PR had, and, without issue -
[https://github.com/apache/age/pull/2165#issuecomment-3558965443](https://github.com/apache/age/pull/2165#issuecomment-3558965443)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PG18 port for AGE [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #2251:
URL: https://github.com/apache/age/pull/2251#issuecomment-3563493238
@MuhammadTahaNaveed @kk-src I built this locally and it builds without errors. I have not reviewed the code, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PG18 port for AGE [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #2251:
URL: https://github.com/apache/age/pull/2251#issuecomment-3573149692
> The commits with signing has been updated as well. Please let me know next steps.
Right now, the next steps are our reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PG18 port for AGE [age]
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #2251:
URL: https://github.com/apache/age/pull/2251#issuecomment-3576240731
@kk-src Thank you for your valuable contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PG18 port for AGE [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #2251:
URL: https://github.com/apache/age/pull/2251#issuecomment-3563537628
@kk-src It looks like this PR isn't up-to-date with this [**PG18**] branch and is based off the **master** branch. I would recommend rebasing it against this branch to be safe. Or, we use the rebase and merge option. @MuhammadTahaNaveed thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org