You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/03/11 18:30:39 UTC
[GitHub] [ignite] antonovsergey93 opened a new pull request #7516:
IGNITE-12774 Fix transaction hanging after too many open files exception.
antonovsergey93 opened a new pull request #7516: IGNITE-12774 Fix transaction hanging after too many open files exception.
URL: https://github.com/apache/ignite/pull/7516
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] asfgit closed pull request #7516: IGNITE-12774 Fix
transaction hanging after too many open files exception.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #7516: IGNITE-12774 Fix transaction hanging after too many open files exception.
URL: https://github.com/apache/ignite/pull/7516
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] macrergate commented on a change in pull request #7516:
IGNITE-12774 Fix transaction hanging after too many open files exception.
Posted by GitBox <gi...@apache.org>.
macrergate commented on a change in pull request #7516: IGNITE-12774 Fix transaction hanging after too many open files exception.
URL: https://github.com/apache/ignite/pull/7516#discussion_r391545079
##########
File path: modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java
##########
@@ -3766,6 +3775,40 @@ else if (rcvCnt < 0)
return ses;
}
+ /**
+ * Opens a socket channel.
+ *
+ * @return A new socket channel.
+ * @throws IOException If an I/O error occurs.
+ */
+ protected SocketChannel openSocketChannel() throws IOException {
+ return SocketChannel.open();
+ }
+
+ /**
+ * Closing connections to node.
+ * NOTE: It is recommended only for tests.
+ *
+ * @param nodeId Node for which to close connections.
+ * @throws IgniteCheckedException If occurs.
+ */
+ void closeConnections(UUID nodeId) throws IgniteCheckedException {
Review comment:
Hi, Sergey! Is this good approach adding a **testing** method to this class? I see it already has thousands of lines. Maybe better to move it to the test class and make the same job via reflection?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services