You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rsafonseca <gi...@git.apache.org> on 2015/06/18 22:08:31 UTC
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/482
This is a quick fix to attempt to resolve most of the travis failures
Most of the failures have been due to transient network failures, that are causing dependency artifact downloads to fail
Maven does not have a way to retry this without restarting the whole build, so the mvn dependency plugin is the best bet
Unfortunately, running a dependency:resolve on the project returns yet to be compiled dependencies, and causes it to fail...
There is an option to excludeGroupIds and excludeArtifactIds in the docs for this goal, but unfortunately they don't seem to work
This drafts a dummy pom in a quick and dirty way, just to download all the deps in one go, while retrying for RETRY_COUNT times if it fails
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca/cloudstack fixtravis
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/482.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #482
----
commit a57cb43f9b15ecd9beb86ae3ce56b3db25f0c497
Author: Rafael da Fonseca <rs...@gmail.com>
Date: 2015-06-18T20:04:51Z
This is a quick fix to attempt to resolve most of the travis failures
Most of the failures have been due to transient network failures, that are causing dependency artifact downloads to fail
Maven does not have a way to retry this without restarting the whole build, so the mvn dependency plugin is the best bet
Unfortunately, running a dependency:resolve on the project returns yet to be compiled dependencies, and causes it to fail...
There is an option to excludeGroupIds and excludeArtifactIds in the docs for this goal, but unfortunately they don't seem to work
This drafts a dummy pom in a quick and dirty way, just to download all the deps in one go, while retrying for RETRY_COUNT times if it fails
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113321916
Travis is still not looking very well :( will resume soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113585258
It seems like this test sometimes fails because the SSVM takes a while to startup.. the test/integration/smoke/test_secondary_storage.py:159 asserts that "Starting" != "Running" and just exits there.
This needs to allow some time for the SSVM to start if state="Starting" instead of immediately throwing an AssertionError.
File hasn't been touched for over a year, so i guess this is a pretty old issue on travis, also explains why it's intermittent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113852244
I'd say this now downloads around 99% of project dependencies before build starts
Mostly just maven-remote-resources-plugin stuff is still downloaded, plus very few others that somehow are not picked-up by the script runs... hopefully 99% will be enough to have travis never fail with download error/timeouts.. will launch some load on travis to see :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113522017
Are you done with this @rsafonseca ? As in; should I merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113284857
Travis failure on 2c0d07e was due to second phase not running after i moved the script to tools/travis
xerxesImpl is downloaded on that phase
Issue is already fixed is in d2faa90
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113487647
7 successes in a row is looking better :)
Will do a couple more minor changes to force some more runs.. will rebase at the end when it feels like travis is running stable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113644292
It seems latest fix uncovered tests that were failing but actually reporting success!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113577142
Perfect, last travis failure was just what i was referring to in the last comment, after_failure.sh printed full marvin logs, we can properly troubleshoot that issue now :)
Will look into that later or during the weekend if no one else beats me to it hehe :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113882368
LGTM waiting for travis to agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113614309
Ever since i first saw this failure I wondered... why is this considered a success?!?
=== TestName: test_02_sys_template_ready | Status : EXCEPTION ===
+----------------------------+---------+
| test_02_sys_template_ready | Success |
+----------------------------+---------+
Fixed in the latest commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113532978
@DaanHoogland LGTM, altough travis has been very stable today :)
Lastest commit is also useful, since the after_failure.sh script was doing nothing at all.. this will allow some insight into failures such as these:
https://travis-ci.org/apache/cloudstack/jobs/67514846
==== Marvin Init Successful ====
=== TestName: test_01_sys_vm_start | Status : FAILED ===
=== TestName: test_02_sys_template_ready | Status : EXCEPTION ===
===final results are now copied to: /tmp//MarvinLogs/test_secondary_storage_KYYYZV===
+----------------------------+---------+
| Test | Result |
+============================+=========+
| test_01_sys_vm_start | Failure |
+----------------------------+---------+
| test_02_sys_template_ready | Success |
+----------------------------+---------+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113610266
Mentioned issue fixed in https://github.com/apache/cloudstack/pull/493/
:D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---