You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/12 19:23:16 UTC

[GitHub] [geode] DonalEvans commented on a change in pull request #6891: GEODE-9627: Add service provider interface to register DataSerializableFixedIDs

DonalEvans commented on a change in pull request #6891:
URL: https://github.com/apache/geode/pull/6891#discussion_r727422196



##########
File path: geode-for-redis/src/main/resources/META-INF/services/org.apache.geode.internal.DSFIDLoader
##########
@@ -0,0 +1 @@
+org.apache.geode.redis.internal.GeodeRedisService

Review comment:
       This file doesn't have the Apache license header, (neither do the equivalent files for `DSFIDLoader` and `DataSerializableFixedIdLoader`) but the one for `DataSerializableFixedIdRegistrant` does. For consistency, should all these files either include or not include the header?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org