You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/14 08:33:26 UTC

[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

nizhikov commented on PR #12632:
URL: https://github.com/apache/kafka/pull/12632#issuecomment-1246427376

   @C0urante Thanks for the review. Fixed all your comments.
   
   > Should we also update the system test
   
   I doubt it.
   
   a. We have compatibility tests (which not use streams resetter at the moment). see - [streams_broker_compatibility_test.py](https://github.com/apache/kafka/blob/trunk/tests/kafkatest/tests/streams/streams_broker_compatibility_test.py#L82).
   So it's possible then in future we will try to use `kafka-streams-application-reset.sh` for previously released Kafka versions which knows nothing about new parameter.
   
   b. At the moment I don't have test environment to check changes in system tests :).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org