You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King, III (JIRA)" <ji...@apache.org> on 2017/01/11 15:48:58 UTC
[jira] [Updated] (THRIFT-3873) Fix various compiler warnings when
using VS2010
[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James E. King, III updated THRIFT-3873:
---------------------------------------
Description:
While verifying a defect I had to build the windows thrift C++ library and found a number of compiler warnings that needed to be cleaned up. As part of cleaning these up, I found that additional compilers were also posting warnings.
Acceptance Criteria:
# I can build successfully with Visual Studio 2010 targeting x86 debug mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2010 targeting x86 release mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2010 targeting x64 debug mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2010 targeting x64 release mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2015 targeting x86 debug mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2015 targeting x86 release mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2015 targeting x64 debug mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2015 targeting x64 release mode with /WX (warnings are errors).
Follow-up: I got pretty close to this ideal goal, but not quite there. There were improvements nonetheless and I was able to successfully build with Visual Studio 2010, 2012, 2013, and 2015, Debug or Release, Win32 or x64 modes and pass unit tests. As such I didn't meet all the criteria of removing every warning, but the majority are gone.
was:
While verifying a defect I had to build the windows thrift C++ library and found a number of compiler warnings that needed to be cleaned up. As part of cleaning these up, I found that additional compilers were also posting warnings.
Acceptance Criteria:
# I can build successfully with Visual Studio 2010 targeting x86 debug mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2010 targeting x86 release mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2010 targeting x64 debug mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2010 targeting x64 release mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2015 targeting x86 debug mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2015 targeting x86 release mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2015 targeting x64 debug mode with /WX (warnings are errors).
# I can build successfully with Visual Studio 2015 targeting x64 release mode with /WX (warnings are errors).
> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
> Key: THRIFT-3873
> URL: https://issues.apache.org/jira/browse/THRIFT-3873
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: VS2010, Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> While verifying a defect I had to build the windows thrift C++ library and found a number of compiler warnings that needed to be cleaned up. As part of cleaning these up, I found that additional compilers were also posting warnings.
> Acceptance Criteria:
> # I can build successfully with Visual Studio 2010 targeting x86 debug mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x86 release mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x64 debug mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x64 release mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x86 debug mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x86 release mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x64 debug mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x64 release mode with /WX (warnings are errors).
> Follow-up: I got pretty close to this ideal goal, but not quite there. There were improvements nonetheless and I was able to successfully build with Visual Studio 2010, 2012, 2013, and 2015, Debug or Release, Win32 or x64 modes and pass unit tests. As such I didn't meet all the criteria of removing every warning, but the majority are gone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)