You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by kf...@collab.net on 2004/09/20 18:33:40 UTC

Re: Incoherent patch guidelines

Grzegorz Adam Hankiewicz <gr...@titanium.sabren.com> writes:
> The patch guidelines in the HACKING file state that the recommended
> way to send patches is included in the body of the message. On the
> other hand, http://subversion.tigris.org/mailing-list-guidelines.html
> states that the best is to attach them. What will it be then?

I forgot to adjust HACKING after we agreed that attachments were
better.  I'll fix HACKING now, sorry for the confusion.

> About writing log messages, it is unclear how to deal with patches
> which deal with only a single file. Specifying it in the log
> message itself seems quite useless because the generated patch
> already contains a path reference to the file being modified. IOW,
> the guideline illustrates the complex example and fails to show a
> basic version for one line patches.

For consistency, it should be done the same way even for one file.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org