You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/29 18:28:33 UTC

[GitHub] [spark] rdblue edited a comment on issue #24689: [SPARK-26946][SQL][FOLLOWUP] Require lookup function

rdblue edited a comment on issue #24689: [SPARK-26946][SQL][FOLLOWUP] Require lookup function
URL: https://github.com/apache/spark/pull/24689#issuecomment-497055324
 
 
   Looks good to me. One minor comment: it doesn't look like Analyzer implementations created in BaseSessionStateBuilder actually override the lookup method to call the session's catalog lookup. I would probably include that in this PR, but we can also add it in later PRs when it is used.
   
   +1, I think this is ready to merge either way.
   
   @cloud-fan, @dongjoon-hyun, @HyukjinKwon, could you take a look at this DSv2 PR? Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org