You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/17 18:34:21 UTC
[GitHub] [apisix-website] barchielAbyss opened a new pull request, #1098: feat: try 2 use code.json config, translations website
barchielAbyss opened a new pull request, #1098:
URL: https://github.com/apache/apisix-website/pull/1098
i want try to try add i18n code.json in website, like docusaurus docs: https://docusaurus.io/docs/i18n/tutorial
Do you have any better ideas, can call to me email
Screenshots of the change:
<img width="709" alt="image" src="https://user-images.githubusercontent.com/23497322/168885103-74e62726-b553-46a7-a835-c1ed04f91055.png">
<img width="979" alt="image" src="https://user-images.githubusercontent.com/23497322/168885608-25b70dd7-1cf2-4712-8279-1c4be185a3ef.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] github-actions[bot] commented on pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #1098:
URL: https://github.com/apache/apisix-website/pull/1098#issuecomment-1129495900
<!-- NETLIFY DEPLOY COMMENT GENERATED BY ACTIONS_NETLIFY - APP ID SHA256: 4a1e2936f4b00e970c8b5babdfe5b33e6e83e97b6f6d6dda75b1fe8399056321 -->
🚀 Deployed on https://628455a7667f0f0ef441db67--apache-apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] barchielAbyss closed pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
barchielAbyss closed pull request #1098: feat: try 2 use code.json config, translations website
URL: https://github.com/apache/apisix-website/pull/1098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SylviaBABY commented on a diff in pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #1098:
URL: https://github.com/apache/apisix-website/pull/1098#discussion_r875392613
##########
website/i18n/zh/code.json:
##########
@@ -0,0 +1,34 @@
+{
+ "hero.webpage.title.fragment1": {
+ "message": "简洁且敏捷的",
+ "description": "Effortless and smooth"
+ },
+ "hero.webpage.title.fragment2": {
+ "message": "API 信息",
+ "description": "API Traffic"
+ },
+ "hero.webpage.title.fragment3": {
+ "message": "管理",
+ "description": "management"
+ },
+ "hero.webpage.subtitle.content": {
+ "message": "Apache APISIX 提供了丰富的流量管理功能，如负载平衡、Dynamic Upstream、蜡烛版本、代码断路器、身份校验、所见即所得等...",
+ "description": "Apache APISIX provides rich traffic management features like Load Balancing, Dynamic Upstream, Canary Release, Circuit Breaking, Authentication, Observability, and more..."
+ },
+ "hero.webpage.download.btn": {
+ "message": "立即体验",
+ "description": "Download"
+ },
+ "arrowAnim.webpage.link.btn": {
+ "message": "阅读文档",
+ "description": "Go to docs..."
+ },
+ "docs.webpage.title.Document": {
+ "message": "文档",
+ "description": "Document"
+ },
+ "docs.webpage.title.DocumentSubtitle": {
+ "message": "开源代表着一种向善的力量",
Review Comment:
个人建议：由于这句话是显示在「文档」页面，所以或许加一个解释文档作用的话可能看起来会更好一些。
这里直接放描述开源的话，感觉突然氛围描述很大而且转折看起来有些奇怪。
<img width="814" alt="image" src="https://user-images.githubusercontent.com/39793568/168938889-299effa5-0896-445b-b24b-3394585186b8.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] barchielAbyss commented on a diff in pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
barchielAbyss commented on code in PR #1098:
URL: https://github.com/apache/apisix-website/pull/1098#discussion_r875393537
##########
website/i18n/zh/code.json:
##########
@@ -0,0 +1,34 @@
+{
+ "hero.webpage.title.fragment1": {
+ "message": "简洁且敏捷的",
+ "description": "Effortless and smooth"
+ },
+ "hero.webpage.title.fragment2": {
+ "message": "API 信息",
+ "description": "API Traffic"
+ },
+ "hero.webpage.title.fragment3": {
+ "message": "管理",
+ "description": "management"
+ },
+ "hero.webpage.subtitle.content": {
+ "message": "Apache APISIX 提供了丰富的流量管理功能，如负载平衡、Dynamic Upstream、蜡烛版本、代码断路器、身份校验、所见即所得等...",
+ "description": "Apache APISIX provides rich traffic management features like Load Balancing, Dynamic Upstream, Canary Release, Circuit Breaking, Authentication, Observability, and more..."
+ },
+ "hero.webpage.download.btn": {
+ "message": "立即体验",
+ "description": "Download"
+ },
+ "arrowAnim.webpage.link.btn": {
+ "message": "阅读文档",
+ "description": "Go to docs..."
+ },
+ "docs.webpage.title.Document": {
+ "message": "文档",
+ "description": "Document"
+ },
+ "docs.webpage.title.DocumentSubtitle": {
+ "message": "开源代表着一种向善的力量",
Review Comment:
猴
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on PR #1098:
URL: https://github.com/apache/apisix-website/pull/1098#issuecomment-1129469238
Thanks for your contribution! I just switched the target branch to `master`, and could you please resolve those conflicts first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SylviaBABY commented on a diff in pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #1098:
URL: https://github.com/apache/apisix-website/pull/1098#discussion_r875391855
##########
website/i18n/zh/code.json:
##########
@@ -0,0 +1,34 @@
+{
+ "hero.webpage.title.fragment1": {
+ "message": "简洁且敏捷的",
+ "description": "Effortless and smooth"
+ },
+ "hero.webpage.title.fragment2": {
+ "message": "API 信息",
+ "description": "API Traffic"
+ },
+ "hero.webpage.title.fragment3": {
+ "message": "管理",
+ "description": "management"
+ },
+ "hero.webpage.subtitle.content": {
+ "message": "Apache APISIX 提供了丰富的流量管理功能，如负载平衡、Dynamic Upstream、蜡烛版本、代码断路器、身份校验、所见即所得等...",
+ "description": "Apache APISIX provides rich traffic management features like Load Balancing, Dynamic Upstream, Canary Release, Circuit Breaking, Authentication, Observability, and more..."
+ },
+ "hero.webpage.download.btn": {
+ "message": "立即体验",
+ "description": "Download"
+ },
+ "arrowAnim.webpage.link.btn": {
+ "message": "阅读文档",
+ "description": "Go to docs..."
+ },
+ "docs.webpage.title.Document": {
+ "message": "文档",
+ "description": "Document"
+ },
+ "docs.webpage.title.DocumentSubtitle": {
+ "message": "开源代表着一种向善的力量",
Review Comment:
```suggestion
"message": "让产品与技术背后的细节更加可视化",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] barchielAbyss commented on pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
barchielAbyss commented on PR #1098:
URL: https://github.com/apache/apisix-website/pull/1098#issuecomment-1129491408
> Thanks for your contribution! I just switched the target branch to `master`, and could you please resolve those conflicts first?
may be i need open the new PR,cherry-pick to my forked warehouse master, i see this commit
chore: test labeler (#1071) c38f6153335378344595f0456c0cb2acf9449403,
it's can't merge 2 master branch, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on PR #1098:
URL: https://github.com/apache/apisix-website/pull/1098#issuecomment-1129522341
> > Thanks for your contribution! I just switched the target branch to `master`, and could you please resolve those conflicts first?
>
> may be i need open the new PR,cherry-pick to my forked warehouse master, i see this commit chore: test labeler (#1071) [c38f615](https://github.com/apache/apisix-website/commit/c38f6153335378344595f0456c0cb2acf9449403), it's can't merge 2 master branch, right?
Ah, cherry-pick is also a good way!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a diff in pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #1098:
URL: https://github.com/apache/apisix-website/pull/1098#discussion_r875389268
##########
website/i18n/zh/code.json:
##########
@@ -0,0 +1,34 @@
+{
+ "hero.webpage.title.fragment1": {
+ "message": "简洁且敏捷的",
+ "description": "Effortless and smooth"
+ },
+ "hero.webpage.title.fragment2": {
+ "message": "API 信息",
+ "description": "API Traffic"
+ },
+ "hero.webpage.title.fragment3": {
+ "message": "管理",
+ "description": "management"
+ },
+ "hero.webpage.subtitle.content": {
+ "message": "Apache APISIX 提供了丰富的流量管理功能，如负载平衡、Dynamic Upstream、蜡烛版本、代码断路器、身份校验、所见即所得等...",
Review Comment:
```suggestion
"message": "Apache APISIX 提供了丰富的流量管理功能，如负载平衡、动态上游、金丝雀发布、断路器、身份校验、可观测性等",
```
##########
website/i18n/zh/code.json:
##########
@@ -0,0 +1,34 @@
+{
+ "hero.webpage.title.fragment1": {
+ "message": "简洁且敏捷的",
+ "description": "Effortless and smooth"
+ },
+ "hero.webpage.title.fragment2": {
+ "message": "API 信息",
Review Comment:
```suggestion
"message": "API 流量",
```
##########
website/i18n/zh/code.json:
##########
@@ -0,0 +1,34 @@
+{
+ "hero.webpage.title.fragment1": {
+ "message": "简洁且敏捷的",
Review Comment:
```suggestion
"message": "简洁高效的",
```
##########
website/i18n/zh/code.json:
##########
@@ -0,0 +1,34 @@
+{
+ "hero.webpage.title.fragment1": {
+ "message": "简洁且敏捷的",
+ "description": "Effortless and smooth"
+ },
+ "hero.webpage.title.fragment2": {
+ "message": "API 信息",
+ "description": "API Traffic"
+ },
+ "hero.webpage.title.fragment3": {
+ "message": "管理",
+ "description": "management"
+ },
+ "hero.webpage.subtitle.content": {
+ "message": "Apache APISIX 提供了丰富的流量管理功能，如负载平衡、Dynamic Upstream、蜡烛版本、代码断路器、身份校验、所见即所得等...",
+ "description": "Apache APISIX provides rich traffic management features like Load Balancing, Dynamic Upstream, Canary Release, Circuit Breaking, Authentication, Observability, and more..."
+ },
+ "hero.webpage.download.btn": {
+ "message": "立即体验",
+ "description": "Download"
+ },
+ "arrowAnim.webpage.link.btn": {
+ "message": "阅读文档",
+ "description": "Go to docs..."
+ },
+ "docs.webpage.title.Document": {
+ "message": "文档",
+ "description": "Document"
+ },
+ "docs.webpage.title.DocumentSubtitle": {
+ "message": "开源代表着一种向善的力量",
+ "description": "We love open source."
+ }
+}
Review Comment:
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SylviaBABY commented on a diff in pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #1098:
URL: https://github.com/apache/apisix-website/pull/1098#discussion_r875392613
##########
website/i18n/zh/code.json:
##########
@@ -0,0 +1,34 @@
+{
+ "hero.webpage.title.fragment1": {
+ "message": "简洁且敏捷的",
+ "description": "Effortless and smooth"
+ },
+ "hero.webpage.title.fragment2": {
+ "message": "API 信息",
+ "description": "API Traffic"
+ },
+ "hero.webpage.title.fragment3": {
+ "message": "管理",
+ "description": "management"
+ },
+ "hero.webpage.subtitle.content": {
+ "message": "Apache APISIX 提供了丰富的流量管理功能，如负载平衡、Dynamic Upstream、蜡烛版本、代码断路器、身份校验、所见即所得等...",
+ "description": "Apache APISIX provides rich traffic management features like Load Balancing, Dynamic Upstream, Canary Release, Circuit Breaking, Authentication, Observability, and more..."
+ },
+ "hero.webpage.download.btn": {
+ "message": "立即体验",
+ "description": "Download"
+ },
+ "arrowAnim.webpage.link.btn": {
+ "message": "阅读文档",
+ "description": "Go to docs..."
+ },
+ "docs.webpage.title.Document": {
+ "message": "文档",
+ "description": "Document"
+ },
+ "docs.webpage.title.DocumentSubtitle": {
+ "message": "开源代表着一种向善的力量",
Review Comment:
个人建议：由于这句话是显示在「文档」页面，所以或许加一个解释文档作用的话可能看起来会更好一些。
这里直接放描述开源的话，感觉突然氛围描述很大而且转折看起来有些奇怪。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #1098: feat: try 2 use code.json config, translations website
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on PR #1098:
URL: https://github.com/apache/apisix-website/pull/1098#issuecomment-1129488529
### <span aria-hidden="true">👷</span> Deploy Preview for *apache-apisix* processing.
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 5db02623a295a9aac6f92b9e3d173536dd5ded4d |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/62845327676acd0008291f0b |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org