You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/06 05:03:37 UTC
[GitHub] [flink] dianfu opened a new pull request #11027:
[FLINK-15929][python] Update the version limit of grpcio to 1.26.0
dianfu opened a new pull request #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027
## What is the purpose of the change
*This pull request updates the version limit of grpcio to 1.26.0 to address the test failure.*
## Brief change log
- *Updates the version limit of grpcio to 1.26.0*
## Verifying this change
This change can be covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] sunjincheng121 commented on a change in pull request
#11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
sunjincheng121 commented on a change in pull request #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027#discussion_r375641893
##########
File path: flink-python/tox.ini
##########
@@ -28,7 +28,7 @@ whitelist_externals=
/bin/bash
deps =
pytest
- grpcio>=1.3.5,<=1.14.2
+ grpcio>=1.3.5,<=1.26.0
Review comment:
1.3.5 -> 1.20.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu closed pull request #11027: [FLINK-15929][python]
Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11027: [FLINK-15929][python]
Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027#issuecomment-582738895
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 52adec60ff360ddcf2eb558bea1a9698612616b4 (Thu Feb 06 05:05:30 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] sunjincheng121 commented on a change in pull request
#11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
sunjincheng121 commented on a change in pull request #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027#discussion_r375641893
##########
File path: flink-python/tox.ini
##########
@@ -28,7 +28,7 @@ whitelist_externals=
/bin/bash
deps =
pytest
- grpcio>=1.3.5,<=1.14.2
+ grpcio>=1.3.5,<=1.26.0
Review comment:
1.3.5 -> 1.22.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11027: [FLINK-15929][python]
Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027#issuecomment-582748569
<!--
Meta data
Hash:e8d78936e5aba3b1df01996889a72332dcf6002b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e8d78936e5aba3b1df01996889a72332dcf6002b
-->
## CI report:
* e8d78936e5aba3b1df01996889a72332dcf6002b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on issue #11027: [FLINK-15929][python]
Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027#issuecomment-582769286
The Python tests have passed: https://api.travis-ci.org/v3/job/646724143/log.txt. Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] sunjincheng121 commented on a change in pull request
#11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
sunjincheng121 commented on a change in pull request #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027#discussion_r375641893
##########
File path: flink-python/tox.ini
##########
@@ -28,7 +28,7 @@ whitelist_externals=
/bin/bash
deps =
pytest
- grpcio>=1.3.5,<=1.14.2
+ grpcio>=1.3.5,<=1.26.0
Review comment:
1.3.5 -> 1.20.0? as 1.4.2 is not available?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11027:
[FLINK-15929][python] Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027#issuecomment-582748569
<!--
Meta data
Hash:e8d78936e5aba3b1df01996889a72332dcf6002b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4884 TriggerType:PUSH TriggerID:e8d78936e5aba3b1df01996889a72332dcf6002b
Hash:e8d78936e5aba3b1df01996889a72332dcf6002b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147660316 TriggerType:PUSH TriggerID:e8d78936e5aba3b1df01996889a72332dcf6002b
-->
## CI report:
* e8d78936e5aba3b1df01996889a72332dcf6002b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147660316) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4884)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11027:
[FLINK-15929][python] Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027#discussion_r375648317
##########
File path: flink-python/tox.ini
##########
@@ -28,7 +28,7 @@ whitelist_externals=
/bin/bash
deps =
pytest
- grpcio>=1.3.5,<=1.14.2
+ grpcio>=1.3.5,<=1.26.0
Review comment:
Good catch! I checked that the minimum version could be 1.17.0 and have updated the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on issue #11027: [FLINK-15929][python]
Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027#issuecomment-582745557
@sunjincheng121 Thanks for the review. Will merge it once the travis turns green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11027:
[FLINK-15929][python] Update the version limit of grpcio to 1.26.0
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11027: [FLINK-15929][python] Update the version limit of grpcio to 1.26.0
URL: https://github.com/apache/flink/pull/11027#issuecomment-582748569
<!--
Meta data
Hash:e8d78936e5aba3b1df01996889a72332dcf6002b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4884 TriggerType:PUSH TriggerID:e8d78936e5aba3b1df01996889a72332dcf6002b
Hash:e8d78936e5aba3b1df01996889a72332dcf6002b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147660316 TriggerType:PUSH TriggerID:e8d78936e5aba3b1df01996889a72332dcf6002b
-->
## CI report:
* e8d78936e5aba3b1df01996889a72332dcf6002b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147660316) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4884)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services