You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@gmail.com> on 2017/02/02 23:50:35 UTC
Review Request 56260: [ATLAS-1523] Implement GET entity by guid and
unique attributes in V2 Entity API using AtlasObjectID
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0fb16c6
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ce8d4c7
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java c42f95f
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 4c79cef
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/#review164076
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 608)
<https://reviews.apache.org/r/56260/#comment235632>
Since this is applicable only for struct/entity/classification types, consider replacing use of generic AtlasType with AtlasStructType. With this change, the method would be:
Consider using the following:
AtlasAttribute attribute = structType.getAttribute(attributeName);
if (attribute != null) {
return attribute.getQualifiedAttributeName().
}
}
return null;
Also update the another variation of this method (above).
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 635)
<https://reviews.apache.org/r/56260/#comment235634>
Since this is applicable only for struct/entity/classification, consider using AtlasStructType instead of generic AtlasType.
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 1033)
<https://reviews.apache.org/r/56260/#comment235645>
"actualPropertyName" ==> "vertexPropertyName"
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 1034)
<https://reviews.apache.org/r/56260/#comment235644>
Consider adding method AtlasAttribute.getEncodedPropertyName() - which can be computed once and avoid the overhead.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java (line 124)
<https://reviews.apache.org/r/56260/#comment235647>
Consider passing the following parameters to this method:
mapAttributesToEntity(AtlasVertex vertex, AtlasStructType structType, AtlasStruct instance)
This method can be used to read attributes for entity/struct/classification types.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java (line 176)
<https://reviews.apache.org/r/56260/#comment235646>
- there should be only one edge for a given classification from an entity; hence only a single vertex at most
- reading the attributes should be same as reading struct/entity attributes. Consider using a single method to read attributes of an instance of struct/entity/classification, given a vertex and AtlasStructType. Please refer to my earlier comment in mapAttributesToEntity()
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java (line 199)
<https://reviews.apache.org/r/56260/#comment235641>
Is "entityType" needed in this method?
It is only used to get edge label. I would suggest to add method AtlasAttribute.getEdgeLabel() and use this to get the edge lable everywhere.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java (line 203)
<https://reviews.apache.org/r/56260/#comment235643>
Use attribute.getAttributeType(), instead of typeRegistry.getType(attribute.getTypeName())
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java (line 218)
<https://reviews.apache.org/r/56260/#comment235648>
- for STRUCT type, the value would be AtlasStruct
- for ENTITY type, the value would be AtlasObjectId
Please review and update.
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java (line 163)
<https://reviews.apache.org/r/56260/#comment235637>
"typeName" should be pathParam. Similar to getByUniqueAttribute(). It will be useful to be able specify multiple attribute/values in the param
- Madhan Neethiraj
On Feb. 3, 2017, 1:36 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56260/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 1:36 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1523
> https://issues.apache.org/jira/browse/ATLAS-1523
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0fb16c6
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ce8d4c7
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java c42f95f
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 4c79cef
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 546cd0c
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java aa209f9
>
> Diff: https://reviews.apache.org/r/56260/diff/
>
>
> Testing
> -------
>
> Tested using POSTMAN
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
> On Feb. 5, 2017, 11:24 p.m., Madhan Neethiraj wrote:
> > addons/models/0030-hive_model.json, line 216
> > <https://reviews.apache.org/r/56260/diff/4/?file=1624614#file1624614line216>
> >
> > "typeName": "hive_storagedesc" ==> "typeName": "."
> > - this doesn't look right. please review.
went with the commit, reverted in updated patch
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/#review164318
-----------------------------------------------------------
On Feb. 5, 2017, 11:55 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56260/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2017, 11:55 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1523
> https://issues.apache.org/jira/browse/ATLAS-1523
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 9c0ccf6
>
> Diff: https://reviews.apache.org/r/56260/diff/
>
>
> Testing
> -------
>
> Tested using POSTMAN
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/#review164318
-----------------------------------------------------------
the patch doesn't apply. can you please rebase with the latest master?
addons/models/0030-hive_model.json (line 216)
<https://reviews.apache.org/r/56260/#comment236011>
"typeName": "hive_storagedesc" ==> "typeName": "."
- this doesn't look right. please review.
- Madhan Neethiraj
On Feb. 6, 2017, 7:15 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56260/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 7:15 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1523
> https://issues.apache.org/jira/browse/ATLAS-1523
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 561cf5b
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0fb16c6
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 9494fe4
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ce8d4c7
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java c42f95f
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 4c79cef
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 546cd0c
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java aa209f9
>
> Diff: https://reviews.apache.org/r/56260/diff/
>
>
> Testing
> -------
>
> Tested using POSTMAN
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/#review164373
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java (line 196)
<https://reviews.apache.org/r/56260/#comment236069>
Put and then assign. If somehow other thread manages to clear up the map then a put after assign might not work.
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 660)
<https://reviews.apache.org/r/56260/#comment236070>
Extra braces not needed.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (line 67)
<https://reviews.apache.org/r/56260/#comment236071>
Might be a good idea to rename these two classes, the names are somewhat similar and confusing.
server-api/src/main/java/org/apache/atlas/services/MetadataService.java (line 51)
<https://reviews.apache.org/r/56260/#comment236072>
Revert this
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java (line 414)
<https://reviews.apache.org/r/56260/#comment236074>
It looks like parsing logic for the query parameters of the form attr:key=value. Since it's being used in the context of get by unique attribute REST call, why not just use the key=value as the parameters for the call directly rather than prefixing them with the attr:
Also I don't see a corresponding change in the AtlasClient code to ensure that the call gets translated correctly, each parameter key in the client should be prefixed with "attr:" in this case. If this prefix is dropped then the client code should be ok.
- Apoorv Naik
On Feb. 6, 2017, 9:55 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56260/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 9:55 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1523
> https://issues.apache.org/jira/browse/ATLAS-1523
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java d5d8d9b
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 9c0ccf6
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2d49c47
>
> Diff: https://reviews.apache.org/r/56260/diff/
>
>
> Testing
> -------
>
> Tested using POSTMAN
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/#review164626
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 8, 2017, 3:40 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56260/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 3:40 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1523
> https://issues.apache.org/jira/browse/ATLAS-1523
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 2d6e708
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f9895cf
> intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java e0f24b1
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 5797a69
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaderWithAssociations.java ed1adb4
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java abcf276
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 2b4561d
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 7fe5e14
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 9b2bc9e
> webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0459061
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 6818899
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java a4799e8
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 6cdf9d1
> webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 24c2151
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java bca9091
> webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java b7cc273
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2d49c47
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6c4147c
> webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java 8b51d1b
> webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 8c629b4
>
> Diff: https://reviews.apache.org/r/56260/diff/
>
>
> Testing
> -------
>
> Tested using POSTMAN
> Ran all unit tests
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 7:40 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
fixed quick start
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 2d6e708
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f9895cf
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java e0f24b1
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 5797a69
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaderWithAssociations.java ed1adb4
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java abcf276
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 2b4561d
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 7fe5e14
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 9b2bc9e
webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0459061
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 6818899
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java a4799e8
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 6cdf9d1
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 24c2151
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java bca9091
webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java b7cc273
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2d49c47
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6c4147c
webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java 8b51d1b
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 8c629b4
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Ran all unit tests
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 4:17 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 2d6e708
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f9895cf
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java e0f24b1
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 5797a69
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaderWithAssociations.java ed1adb4
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java abcf276
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 2b4561d
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 7fe5e14
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 9b2bc9e
webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0459061
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 6818899
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java a4799e8
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 6cdf9d1
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 24c2151
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java bca9091
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2d49c47
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6c4147c
webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java 8b51d1b
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 8c629b4
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Ran all unit tests
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 4:08 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
* Rebased patch.
* Added check to include only isOwned Attributes to the referredEntities map.
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 2d6e708
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f9895cf
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java e0f24b1
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 5797a69
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaderWithAssociations.java ed1adb4
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java abcf276
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 2b4561d
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 7fe5e14
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 9b2bc9e
webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0459061
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 6818899
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java a4799e8
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 6cdf9d1
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 24c2151
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java bca9091
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2d49c47
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6c4147c
webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java 8b51d1b
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 8c629b4
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Ran all unit tests
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 8:33 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 2b3669d
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java e0f24b1
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 5797a69
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaderWithAssociations.java ed1adb4
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java abcf276
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 2b4561d
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
server-api/src/main/java/org/apache/atlas/services/MetadataService.java d5d8d9b
webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 1559eb9
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 6818899
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java a4799e8
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 7f5a056
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java af0377e
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 9c0ccf6
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2d49c47
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 18bbc3b
webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java 8b51d1b
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 29a6d49
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Ran all unit tests
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 4:21 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
* Removed all reference to class AtlasEntityHeaderWithAssociations and moved classification list to AtlasEntityHeader
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 2b3669d
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java e0f24b1
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 5797a69
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaderWithAssociations.java ed1adb4
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java abcf276
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 2b4561d
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 1559eb9
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 6818899
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java a4799e8
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 7f5a056
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java af0377e
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 9c0ccf6
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2d49c47
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 18bbc3b
webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java 8b51d1b
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 29a6d49
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Ran all unit tests
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 12:13 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
* Removed AtlasEntityWithAssociations class and all its references.
* Addressed review comments.
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 2b3669d
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java abcf276
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 1559eb9
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 6818899
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java a4799e8
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 7f5a056
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java af0377e
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 9c0ccf6
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2d49c47
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 18bbc3b
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 29a6d49
Diff: https://reviews.apache.org/r/56260/diff/
Testing (updated)
-------
Tested using POSTMAN
Ran all unit tests
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 1:55 a.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
server-api/src/main/java/org/apache/atlas/services/MetadataService.java d5d8d9b
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 9c0ccf6
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2d49c47
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 5, 2017, 11:55 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 9c0ccf6
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 5, 2017, 11:47 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 89e978d
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java ed0fabb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 9e08282
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 6cbb602
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 9c0ccf6
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 5, 2017, 11:15 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
* addressed review comments
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
addons/models/0030-hive_model.json 561cf5b
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0fb16c6
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 9494fe4
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ce8d4c7
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java c42f95f
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 4c79cef
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 546cd0c
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java aa209f9
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 2, 2017, 5:36 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0fb16c6
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ce8d4c7
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java c42f95f
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 4c79cef
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 546cd0c
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java aa209f9
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Thanks,
Sarath Subramanian
Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid
and unique attributes in V2 Entity API using AtlasObjectID
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------
(Updated Feb. 2, 2017, 4:56 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1523
https://issues.apache.org/jira/browse/ATLAS-1523
Repository: atlas
Description
-------
Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0fb16c6
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ce8d4c7
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java c42f95f
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 4c79cef
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 546cd0c
Diff: https://reviews.apache.org/r/56260/diff/
Testing
-------
Tested using POSTMAN
Thanks,
Sarath Subramanian