You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Daniel Rohe (JIRA)" <ji...@codehaus.org> on 2009/10/29 22:37:26 UTC
[jira] Updated: (MECLIPSE-449) Facet Generation generates duplicate
entries - breaks RAD/RSA support
[ http://jira.codehaus.org/browse/MECLIPSE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Rohe updated MECLIPSE-449:
---------------------------------
Attachment: MECLIPSE-449.patch
This is a patch to this bug which checks whether the additional facets overwrite any of the hard-coded installed facets. Also the patch contains a test case which should show the replacement.
> Facet Generation generates duplicate entries - breaks RAD/RSA support
> ---------------------------------------------------------------------
>
> Key: MECLIPSE-449
> URL: http://jira.codehaus.org/browse/MECLIPSE-449
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
> Reporter: Chris Graham
> Fix For: 2.8
>
> Attachments: MECLIPSE-449.patch
>
>
> Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.
> Take this section of the POM:
> <additionalProjectFacets>
> <jst.java>5.0</jst.java>
> <jst.ejb>2.1</jst.ejb>
> <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.utility"/>
> <installed facet="jst.utility" version="1.0"/>
> <installed facet="jst.java" version="5.0"/>
> <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> <installed facet="jst.ejb" version="2.1"/>
> <installed facet="jst.java" version="5.0"/>
> </faceted-project>
> You'll see that the jst.java facet is in there twice.
> Removing the facet from the list:
> <additionalProjectFacets>
> <jst.ejb>2.1</jst.ejb>
> <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.utility"/>
> <installed facet="jst.utility" version="1.0"/>
> <installed facet="jst.java" version="5.0"/>
> <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> <installed facet="jst.ejb" version="2.1"/>
> </faceted-project>
> Which is a little more correct.
> I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.
> Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:
> <?xml version="1.0" encoding="UTF-8"?>
> Also, where does the jst.utility facet come from?
> It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).
> This is the complete RSA generated one, for reference:
> <?xml version="1.0" encoding="UTF-8"?>
> <faceted-project>
> <runtime name="WebSphere Application Server v6.1"/>
> <fixed facet="jst.ejb"/>
> <fixed facet="jst.java"/>
> <installed facet="jst.ejb" version="2.1"/>
> <installed facet="jst.java" version="5.0"/>
> <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>
> (Which raises another question, how do we specify the runtime items and if something is fixed or not?)
> However, to get it to be correctly recognised, all we need is this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <installed facet="jst.java" version="5.0"/>
> <installed facet="jst.ejb" version="2.1"/>
> <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira